Address panic observed while operating with file callbacks#404
Merged
abhinavdangeti merged 4 commits intomasterfrom Apr 29, 2026
Merged
Address panic observed while operating with file callbacks#404abhinavdangeti merged 4 commits intomasterfrom
abhinavdangeti merged 4 commits intomasterfrom
Conversation
+ Separating vector tests out of the original file, to run unrelated tests in non-vectors mode.
Member
|
Looks like this is a real bug, we did not seem to catch this before as the workflows did not run the file callbacks tests - due to it being hidden under the vector go tag. |
CascadingRadium
previously approved these changes
Apr 29, 2026
Member
CascadingRadium
left a comment
There was a problem hiding this comment.
LGTM, i think @Likith101 can address the panic in a separate patch.
No, let's address the failure in this PR - alongside the tests that will now run in CV.
Thejas-bhat
previously approved these changes
Apr 29, 2026
Thejas-bhat
previously approved these changes
Apr 29, 2026
Member
Author
|
Nice one @Likith101 👍🏼 . |
6faf8b8 to
46dfee6
Compare
46dfee6 to
4b9ea56
Compare
Thejas-bhat
approved these changes
Apr 29, 2026
Member
Author
|
|
abhinavdangeti
pushed a commit
to blevesearch/bleve
that referenced
this pull request
Apr 30, 2026
…2326) - This change also comes with bug fixes in cases where we fail to create a centroid index, but the application decides to fallback to the naive merge algorithm instead of fast merge - Brings in these fixes in zapx/v17: * b7d79e6 Abhi Dangeti, Likith B | Address panic observed while operating with file callbacks (blevesearch/zapx#404) * b4e42c5 Thejas-bhat | MB-71216: implement fast merge for binary index class (blevesearch/zapx#393) * ca1c2cf Thejas-bhat | make the `faissIndex` interface and implementation more modular (blevesearch/zapx#403) * f330de0 Likith B | Process In-Memory Segment Bases Before Persisting (blevesearch/zapx#402) * 3468d01 Likith B | MB-71216: Added Support for IVFRaBitQ Indexes (blevesearch/zapx#391)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.