Skip to content

feat: initial implementation - #3

Merged
blimmer merged 26 commits into
mainfrom
initial-implementation
Jan 24, 2025
Merged

feat: initial implementation#3
blimmer merged 26 commits into
mainfrom
initial-implementation

Conversation

@blimmer

@blimmer blimmer commented Jan 21, 2025

Copy link
Copy Markdown
Owner

This is the initial implementation of this construct.

It attempts to resolve the outstanding issues (aripalo/aws-cdk-github-oidc#36 / aripalo/aws-cdk-github-oidc#39 / aripalo/aws-cdk-github-oidc#35 / aripalo/aws-cdk-github-oidc#42).

@blimmer
blimmer requested a review from Copilot January 21, 2025 03:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 24 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • .gitattributes: Language not supported
  • .projen/files.json: Language not supported
  • src/filters/PullRequestFilter.ts: Evaluated as low risk
  • src/IGithubActionsIdentityProvider.ts: Evaluated as low risk
  • src/filters/TagFilter.ts: Evaluated as low risk
  • src/filters/index.ts: Evaluated as low risk
  • src/filters/BranchFilter.ts: Evaluated as low risk
  • src/filters/EnvironmentFilter.ts: Evaluated as low risk
  • src/index.ts: Evaluated as low risk
  • src/filters/IGithubActionOidcFilter.ts: Evaluated as low risk
  • .projenrc.ts: Evaluated as low risk
  • test/filters/EnvironmentFilter.test.ts: Evaluated as low risk
  • test/filters/PullRequestFilter.test.ts: Evaluated as low risk
  • test/filters/CustomFilter.test.ts: Evaluated as low risk
  • test/filters/BranchFilter.test.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/filters/CustomFilter.ts:9

  • [nitpick] The property name 'filter' is ambiguous. It should be renamed to 'customFilter' for better clarity.
filter: string;

@blimmer blimmer changed the title feat: add provider implementation feat: initial implementation Jan 21, 2025
@blimmer
blimmer requested a review from Copilot January 21, 2025 19:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 26 out of 26 changed files in this pull request and generated no comments.

@blimmer
blimmer merged commit 319946a into main Jan 24, 2025
@blimmer
blimmer deleted the initial-implementation branch January 24, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants