fix: org mark and workspace tiles share one 35px size - #110
Merged
Conversation
One custom property ties them so they can never drift apart. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Under the tab strip an ancestor reset hid the gap; under the rail the UA button face and border painted every item as a pill. The menu is self-sufficient now and renders identically at both call sites. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
pythonlearner1025
added a commit
that referenced
this pull request
Sep 1, 2026
The redesign branched at #110, three hours before #112 landed `settings-surface.css` — the `cfg-` canon CLAUDE.md now names as the one system for every settings-shaped screen. Both sides restyled the same surfaces, so the resolution keeps the redesign's STRUCTURE and main's VOCABULARY: primitives, the org switcher, the surface ladder and the danger-zone/About headings survive, expressed in `cfg-` classes rather than in a second set of headings, fields, dividers and fact lists. Per file: - settings.css — the redesign's ladder and its `.settings-switch-*` shape stay; every rule whose markup moved to the canon is gone (definition list, appearance wrapper, `.settings-field*`, `.settings-danger*`, `.settings-note`, `.settings-credential-section`, `.connect-field__label`). The account page keeps its red frame around the canon's `.cfg-danger`. - workspace-details-dialog.css — the ladder's raised cards stay; the heading, field and fact-list rules the canon owns are gone, and #114's credential import and #112's volume meter come across whole. The settings form's machine-type select re-targets `.cfg-field` and takes the one control height. - SettingsPage.tsx — main's `.cfg-meta` profile facts and `.cfg-section` appearance block, plus the redesign's Organizations section, re-headed with `.cfg-section-head` / `.cfg-title`. - MembersPanel.tsx — the redesign's named "Danger zone" over main's `.cfg-danger` / `.cfg-danger-action` zone. - UsagePanel.tsx — the redesign's `SettingsSwitch` (it writes on change, which is what the primitive is for) with main's `.cfg-help` notes. - WorkspaceSettingsTab.tsx — main's `.cfg-field--inline` checkbox, NOT `SettingsSwitch`: that row is part of a draft the Save below sends, and the primitive's own contract forbids a Save beside it. `cfg-actions` and `cfg-meta` as main has them, with the redesign's "About" title. - WorkspaceDetailsDialog.tsx — main's `.cfg-section` credentials tab and its comment field, with the redesign's red Revoke. - CloudApp.tsx — the redesign cuts the desktop statusline; #155's BUG-CV-02 sentence keeps one desktop surface, because a box the browser cannot reach has no other affordance. The bar now shows on desktop when the terminal needs its sign-in pair OR when the gateway is unreachable. Also carried across the version gap: `settings-surface.css` gains the disabled state the redesign gave its danger button, the preview fixtures gain the fields main added to `MachineView`, `WorkspaceCredentialView` and `CatalogEntryView`, the preview gallery passes `refreshWorkspaces`, and two tests drop props the redesign removed. Gates: typecheck and lint:gate pass at baseline (74 anti-slop, 0 house). `npm test` passes except `webapp/test/lody-worktree-composer.test.tsx`, which fails the same way on origin/main alone — a pre-existing failure, not this merge's. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UhdxNAYjV97JTv2pddcJiN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #109. The strip declares
--strip-tile: 35pxand both the org mark and every workspace tile size from it, so the two can never drift apart. Radius and type scale with it.Gates: typecheck 0; lint at baseline; webapp 357 pass.
🤖 Generated with Claude Code