fix(test): the managed upload set is 109 files, not 108 - #117
Merged
Conversation
#114 added core/workspace-credential-import.ts and updated the module manifest and both module lists, but not the third hand-maintained number: the length assertion inside blitzdev-emitter's vendor-only describe. That block is skipIf'd without BLITZDEV_MANAGED=1, so a local `npm test` reported green and CI — which sets the variable — went red on main. This is the trap CLAUDE.md names under "Adding a file under core/ touches three hand-maintained lists". Verified the way that note prescribes: `BLITZDEV_MANAGED=1 npx vitest run` is 64 files and 686 tests green, against 59 and 648 without the variable. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012R7NUDJXy3eUBeKFYTMt1A
pythonlearner1025
added a commit
that referenced
this pull request
Aug 30, 2026
f3474894 fix(electron): detect system language before onboarding (#175) 451dc039 fix: synchronize ACP runtime config across collaborators (#159) 18055309 fix: route pending Agent setup to onboarding summary (#163) 7299043b ci: consolidate PR contribution policy (#171) 8e4e0b3c feat: normalize PR issue closing links c53badf2 test: handle node test promises explicitly 4817f95d ci: classify external PRs by source repository 61f121ad Merge pull request #117 from clanzhang/fix/zh-docs-broken-links 1f9abeb1 Merge pull request #73 from Pleasurecruise/fix/editor-probe 7e07176c fix(docs): correct Chinese doc links to point to /zh/ prefix 0b53ee99 fix: detect available session path launchers git-subtree-dir: vendor/lody git-subtree-split: f34748945028ffc04316861ad25edc24535c0235
pythonlearner1025
added a commit
that referenced
this pull request
Aug 30, 2026
main gained the memory boundary (#113), machine-stats (#112), env-file credential import (#114), the managed-count fix (#117), canary's R2 box image (#115) and the connections/mobile fixes. This branch is the Lody port, which deleted the box actor entirely. How each side was chosen: - `packages/box/actor/**` stays deleted. That was a direct user order and nothing here softens it. main's `actor/run` change is dropped with the service it wrapped. - machine-stats is actor-independent guest work, so it stays: the s6 service, `blitz-machine-stats` and the CP consumer land unchanged, and its conformance test moves to `packages/box/guest-tests/test/` the way the deletion commit re-homed every other guest test. The relative paths the test reads (`../../rootfs`, `../../../schema/fixtures`) resolve at the same depth, so nothing in it needed editing. - The memory boundary's one actor dependency was the placement of the process that hosts agents. The Lody daemon is that process now, so it inherits the scope: `lody-daemon/run` enters `user/lody.scope`, and `docs/MEMORY-BOUNDARY.md`, `blitz-cgroup` and `smoke.sh` say so. The daemon is dark by default, so smoke.sh reads the run script rather than looking for a node that is not there. - `.github/workflows/**` takes main's side whole — this branch never meant to touch canary.yml, and after the merge the directory is byte-identical to origin/main. - `CreateRecipeScreen.tsx` takes main's `cfg-` settings-surface styling and drops the chat-harness copy and `chatNeedsModel`, which have no referent on this branch. - `WorkspaceDetailsDialog.test.tsx` takes main's `IMPORT_PREVIEW_DEBOUNCE_MS` import beside this branch's `SessionRail` rename. - `shell-smoke.test.tsx`: main's new mobile-drawer test passed an `acp` port that `StandalonePorts` no longer has. Adding a file under `core/` touches three hand-maintained lists, and the merge is where two branches' additions meet. All three take the union: `worker-source.mjs` gains main's `workspace-credential-import.ts` beside this branch's `workspace-drain.ts`; `core-imports.test.ts` counts 109 (104 at the fork, +2 from main, +3 here); and the managed upload set in `blitzdev-emitter.test.ts` gains `core/wire-sharing.ts`, `core/session-shares.ts` and `core/workspace-drain.ts` to reach 112. Those three are 2.2 KB, 14 KB and 2.9 KB of source, so the emitter's 1 MiB-per-file platform limit still holds with four orders of magnitude to spare — and the test asserts it on every file, not just the new ones. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vk3ghWvYvp74ae9EUQPPkJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main is red. This is the one-line fix.
#114 added
core/workspace-credential-import.tsand updated the module manifestand both module lists — but not the third hand-maintained number: the length
assertion inside
blitzdev-emitter.test.ts.That assertion lives in a
describe.skipIf(!managedToolchainEnabled)block, soa local
npm testskips it and reports green. CI setsBLITZDEV_MANAGED=1andcaught it. Exactly the trap
CLAUDE.mdnames under "Adding a file undercore/touches three hand-maintained lists".Verified the way that note prescribes:
BLITZDEV_MANAGED=1 npx vitest runnpx vitest run(no variable)The managed run is green across the board, so the skip was hiding this one
failure and nothing else.
🤖 Generated with Claude Code
https://claude.ai/code/session_012R7NUDJXy3eUBeKFYTMt1A