Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the psycopg2-binary dependency to version 2.9.12, which includes critical bug fixes and support for newer Python versions. The project is currently meeting quality standards; however, the update introduces a potential breaking change by dropping support for Python 3.7 and 3.8. No security or logic flaws were identified in the metadata provided, but validation of the runtime environment is required before merging.
About this PR
- Potential breaking change: psycopg2-binary version 2.9.10+ no longer supports Python 3.7 and 3.8. Ensure the scraper's execution environment is running Python 3.9 or newer to avoid runtime failures.
Test suggestions
- Verify that the application successfully connects to the PostgreSQL database using the updated psycopg2-binary 2.9.12 driver.
- Confirm that the execution environment is running Python 3.9 or newer, as support for 3.7 and 3.8 was dropped in versions 2.9.10 and 2.9.11.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the application successfully connects to the PostgreSQL database using the updated psycopg2-binary 2.9.12 driver.
2. Confirm that the execution environment is running Python 3.9 or newer, as support for 3.7 and 3.8 was dropped in versions 2.9.10 and 2.9.11.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot recreate |
Bumps [psycopg2-binary](https://github.com/psycopg/psycopg2) from 2.9.9 to 2.9.12. - [Changelog](https://github.com/psycopg/psycopg2/blob/master/NEWS) - [Commits](psycopg/psycopg2@2.9.9...2.9.12) --- updated-dependencies: - dependency-name: psycopg2-binary dependency-version: 2.9.12 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
9793720 to
34b26d7
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Replace partial SQL string concatenation with a static lookup table of four fully-prewritten queries keyed on (include_drops, has_site_name). No user input ever touches the SQL string itself; site_name is still passed as a parameterized %s value. Fixes CodeQL alert py/sql-injection (alert #37). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ggle (#103) * feat: subcategory auto-discovery, fyndhörna filter, CSV price drop toggle - Revert URL input from textarea back to single field — subcategory pagination now handles category discovery automatically - Add "Auto-discover subcategories" checkbox to add form; inet.se/komplett/ webhallen templates default to subcategory mode with pagination_selector - Add exclude_link_pattern per config: product URLs containing the pattern are silently skipped (inet.se template defaults to /produkt/x to exclude open-box fyndhörna items that caused false -50% drop readings) - Fix urljoin in extract_product: use page.url instead of config base_url (base_url may contain multiple lines after multi-URL feature) - CSV export: add include_drops query param; when enabled adds Was/Drop% columns using price_history; UI shows "Price drops" toggle next to Export Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: eliminate SQL injection vector in export query builder Replace partial SQL string concatenation with a static lookup table of four fully-prewritten queries keyed on (include_drops, has_site_name). No user input ever touches the SQL string itself; site_name is still passed as a parameterized %s value. Fixes CodeQL alert py/sql-injection (alert #37). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: add pagination_selector field for custom subcategory configs Previously the pagination_selector was silently set to '' for any site not matching a known template name, making subcategory auto-discovery non-functional for custom sites. - Show/hide 'Category link selector' input when subcategory checkbox is toggled - loadTemplate populates the field from the template definition - addConfig reads directly from the input instead of template lookup - Move csv/StringIO/Response imports to top-level (style fix) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: decouple site_name from SQL query selection to satisfy CodeQL site_name (URL param) no longer influences which query is selected — export_site_csv always uses the site-specific variant keyed on (include_drops, True), while export_all_csv uses (include_drops, False). site_name only appears in the parameterized tuple passed to cur.execute. Removes _build_export_query helper (no longer needed). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Anders Eriksson <blixten85@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Bumps psycopg2-binary from 2.9.9 to 2.9.12.
Changelog
Sourced from psycopg2-binary's changelog.
... (truncated)
Commits
3a6d9d6ci: include almalinux in whieel buildingebca6bfchore: bump to version 3.9.120196f02build(deps): bump pypa/cibuildwheel from 3.3.1 to 3.4.0d157bdcbuild(deps): bump docker/setup-qemu-action from 3 to 47fccc0fbuild(deps): bump actions/upload-artifact from 6 to 7d52a61echore: bump dependency librariesb231d72chore: fix building binary images6d76e84Merge pull request #1836 from psycopg/fix-1835f7e314cfix: overflow in malformed intervaleb905c1docs: replace bare except clause with except ExceptionSummary by CodeRabbit
Release Notes