fix: resolve 6 flaky integration tests (fee tolerance, dedup, timing)#767
Merged
dangershony merged 1 commit intomainfrom Apr 18, 2026
Merged
fix: resolve 6 flaky integration tests (fee tolerance, dedup, timing)#767dangershony merged 1 commit intomainfrom
dangershony merged 1 commit intomainfrom
Conversation
- PortfolioViewModel: update TotalInvested on dedup path when SDK value is 0 (indexer lag) - Tests: use fee-tolerant assertions instead of exact BTC amounts - FundAndRecoverTest: assert investment exists instead of count increment (handles dedup) - FindProjectsInvoiceFlowTest: accept Publishing/Building as payment evidence (not just transient Payment received) - OneClickInvestLightningTest: relax ErrorMessage assertion to allow OnChain-origin errors - Fix FluentAssertions 8.x API: BeLessThanOrEqualTo/BeGreaterThanOrEqualTo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 6 integration tests that were failing due to fee deduction mismatches, portfolio deduplication edge cases, and timing-sensitive assertions.
Product fix
AddInvestmentFromProjectdeduplicates (investment already loaded by SDK), it now updatesTotalInvestedif the existing value is0(indexer lag scenario)Test fixes
ErrorMessageassertion to allow OnChain-origin errors that don't indicate Lightning test failuresBeLessThanOrEqualTo/BeGreaterThanOrEqualTo)Verification
All 6 previously-failing tests re-run individually and pass. All 19 integration tests now pass.