refactor: enforce UI-driven interaction hierarchy in integration tests

[dangershony]

Summary

• Removed direct new InvestPageViewModel(...) construction from 3 test files (OneClickInvestLightningTest, OneClickInvestOnChainTest, InvestModalsViewFixesTest) — tests now navigate through the UI (Find Projects → OpenProjectDetail → OpenInvestPage) to obtain the ViewModel
• Added // DIRECT SDK CALL: and // DIAGNOSTIC SDK CALL: comments to 4 test files where SDK bypass is justified, documenting why no ViewModel exposes the needed data
• Updated TESTING_GUIDELINES.md with interaction hierarchy rules (UI clicks > VM method calls > direct SDK calls) and expanded the test inventory from 6 to 14 entries
• Created 4 missing markdown docs for OneClickInvestLightningTest, OneClickInvestOnChainTest, InvestModalsViewFixesTest, and FindProjectsPanelTests

All 19 integration tests pass individually.

[dangershony]

Detailed Summary

Problem

Several integration tests were bypassing the UI layer by constructing ViewModels directly with new InvestPageViewModel(...), pulling dependencies out of the DI container manually. This made tests fragile (they break when constructor signatures change) and didn't validate the actual navigation paths users take. Additionally, some tests made direct SDK service calls without documenting why the UI/ViewModel layer couldn't be used instead.

What Changed

1. Eliminated direct ViewModel construction (3 files)

These tests previously resolved IServiceProvider from the test harness, pulled individual services, and called new InvestPageViewModel(...):

• OneClickInvestLightningTest.cs (both LightningInvoiceFlow_FullStateMachine and PortfolioDeduplication_AfterInvestment)
• OneClickInvestOnChainTest.cs (both OnChainInvoiceFlow_FullStateMachine and OnChainInvoiceFlow_TabSwitchRaceCondition)
• InvestModalsViewFixesTest.cs (InvestModals_FixesAreWired)

All now use the UI navigation path: GetFindProjectsViewModel() → OpenProjectDetail(project) → OpenInvestPage() → read findVm.InvestPageViewModel. This matches how the real app creates the InvestPageViewModel via the Func<ProjectItemViewModel, InvestPageViewModel> factory registered in CompositionRoot.cs.

2. Documented justified SDK bypass locations (4 files)

Added standardized comments explaining why direct SDK calls are necessary:

• CreateProjectTest.cs (~line 444) — // DIRECT SDK CALL: fetching the full ProjectDto to validate stage data that no ViewModel exposes
• FindProjectsInvoiceFlowTest.cs (~line 236) — // DIRECT SDK CALL: fetching project stats to verify investor count, not available through any VM
• MultiFundClaimAndRecoverTest.cs — // DIAGNOSTIC SDK CALL: on LogRecoveryBuildDiagnostics helper used in retry loops for troubleshooting flaky recovery builds
• MultiInvestClaimAndRecoverTest.cs — // DIAGNOSTIC SDK CALL: on LogUnfundedReleaseBuildDiagnostics helper, same diagnostic purpose

3. Updated TESTING_GUIDELINES.md

• Added Interaction Hierarchy section defining the preference order: UI-level helpers (TestHelpers.Click*) > ViewModel method calls > direct SDK service calls
• Added rules against constructing ViewModels with new in tests
• Added guidance on when SDK calls are acceptable and how to document them
• Expanded the test inventory from 6 to 14 entries covering all current test files

4. Created 4 missing markdown docs

• OneClickInvestLightningTest.md
• OneClickInvestOnChainTest.md
• InvestModalsViewFixesTest.md
• FindProjectsPanelTests.md

Verification

All 19 integration tests were run individually and pass:

• 2 smoke tests
• 5 refactored tests (the ones that changed)
• 3 FindProjectsPanelTests
• 9 infrastructure tests (SendToSelf, WalletImport, CreateProject, FindProjectsInvoice, FundAndRecover, InvestAndRecover, InvestmentCancellation, MultiFundClaimAndRecover, MultiInvestClaimAndRecover)

[dangershony]

@DavidGershony I wonder do we need this test? it feels more like a unit test then integration what do you think?

The elements being tests are probably already covered in a full integration test.

[DavidGershony]

We still had the issue that nothing worked at some point.