Fix wallet encryption key mismatch, surface real errors, and restore scan button#781
Merged
dangershony merged 2 commits intomainfrom Apr 23, 2026
Merged
Conversation
…d restore scan button - Fix CreateWalletWithoutPassword using 'DEFAULT' key instead of 'default-key', causing 'Invalid encryption key' on all SDK operations for invest-flow wallets - Add Result.IsFailure checks in CreateProjectProfile and CreateProjectInfo handlers to prevent ResultFailureException crashes - Surface actual error messages in ManageProject claim/release toasts instead of generic 'Please try again' messages - Auto-scale toast duration based on message length (3-10s) so error messages are readable - Restore desktop Scan for Projects button removed in mobile responsive port - Add encryption key roundtrip regression tests in CreateProjectTest, OneClickInvestOnChainFundedTest, and OneClickInvestLightningFundedTest
…lure guard was added to CreateProjectProfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateWalletWithoutPasswordencrypted with"DEFAULT"butSimplePasswordProviderdecrypts with"default-key", causing"Invalid encryption key"on all SDK operations (deploy, sign, claim) for wallets auto-created by the invest flowCreateProjectProfileandCreateProjectInfohandlers accessedwallet.Valuewithout checkingIsFailure, turning a graceful error into aResultFailureExceptionCreateProjectTest,OneClickInvestOnChainFundedTest, andOneClickInvestLightningFundedTestFiles Changed
WalletAppService.cs"DEFAULT"to"default-key"CreateProjectProfile.cswallet.IsFailurecheckCreateProjectInfo.cswallet.IsFailurecheckManageProjectViewModel.csShellViewModel.csMyProjectsView.axamlCreateProjectTest.csOneClickInvestOnChainFundedTest.csOneClickInvestLightningFundedTest.cs