Fix InvestModalsViewFixesTest timing: accept any valid progress text#782
Merged
dangershony merged 1 commit intomainfrom Apr 24, 2026
Merged
Fix InvestModalsViewFixesTest timing: accept any valid progress text#782dangershony merged 1 commit intomainfrom
dangershony merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix flaky InvestModalsViewFixesTest that always fails because PaymentStatusText assertions expect exact strings that get overwritten by the reactive command synchronous preamble.
Root Cause
ShowInvoice() sets PaymentStatusText then immediately fires PayViaInvoice(). The ReactiveCommand runs synchronously up to its first await - when no wallet exists (clean test profile), EnsureWalletExistsAsync overwrites the text to Creating wallet before the test assertion runs. Same issue on the Lightning tab path.
Fix
Replace exact string assertions with BeOneOf(validProgressStrings) that accept any legitimate progress message. The test still verifies the core invariant: the user sees immediate feedback (not a frozen placeholder).