Fixes an issue when reindex takes more than one minute (#351)

- The .Tip is null if the "FlushChain" is run before reindex has completed.

Author: sondreb

src/Blockcore/Base/BaseFeature.cs

@@ -289,15 +289,18 @@ private async Task StartChainAsync()
                 }
 
                 // Get latest flags (often cached) and persist.
-                var flags = this.nodeDeployments.GetFlags(this.consensusManager.Tip);
-
-                if (this.deploymentFlags == null || flags.ScriptFlags != this.deploymentFlags.ScriptFlags)
+                if (this.consensusManager.Tip != null)
                 {
-                    // Update the persistent disk cache of Flags when we retrieve it.
-                    this.keyValueRepo.SaveValueJson("deploymentflags", flags);
+                    var flags = this.nodeDeployments.GetFlags(this.consensusManager.Tip);
+
+                    if (this.deploymentFlags == null || flags.ScriptFlags != this.deploymentFlags.ScriptFlags)
+                    {
+                        // Update the persistent disk cache of Flags when we retrieve it.
+                        this.keyValueRepo.SaveValueJson("deploymentflags", flags);
 
-                    // Update the local cached copy used to validate against. We don't want to persist to disk unless the flags actually has changed.
-                    this.deploymentFlags = flags;
+                        // Update the local cached copy used to validate against. We don't want to persist to disk unless the flags actually has changed.
+                        this.deploymentFlags = flags;
+                    }
                 }
             },
             this.nodeLifetime.ApplicationStopping,

src/Node/Blockcore.Node/Properties/launchSettings.json

@@ -46,7 +46,7 @@
     },
     "CITY (MAIN/LOCAL)": {
       "commandName": "Project",
-      "commandLineArgs": "--chain=CITY -server -addressindex -rpcallowip=127.0.0.1 -rpcbind=127.0.0.1 -rpcpassword=rpcpassword -rpcuser=rpcuser -datadir=nodedata -enableauth=0"
+      "commandLineArgs": "--chain=CITY -server -addressindex -txindex=1 -reindex=0 -rpcallowip=127.0.0.1 -rpcbind=127.0.0.1 -rpcpassword=rpcpassword -rpcuser=rpcuser -datadir=nodedata -enableauth=0"
     },
     "CITY (TEST/LOCAL)": {
       "commandName": "Project",