Add XDS network (#83)

* First commit copy of stratis

* Add XDS network

* Get network to sync. and fix a consensus bug

* Fix create genesis bug

* Fix dust error

Author: dangershony

src/Blockcore.Features.ColdStaking.Tests/ColdStakingControllerTest.cs

@@ -108,7 +108,7 @@ private void MockStakeChain()
             {
                 Flags = BlockFlag.BLOCK_PROOF_OF_STAKE,
                 StakeModifierV2 = 0,
-                StakeTime = (this.chainIndexer.Tip.Header.Time + 60) & ~PosConsensusOptions.StakeTimestampMask
+                StakeTime = (this.chainIndexer.Tip.Header.Time + 60) & ~this.Network.Consensus.ProofOfStakeTimestampMask
             });
         }
 

src/Blockcore.Features.ColdStaking/ColdStakingManager.cs

@@ -360,7 +360,7 @@ internal Transaction GetColdStakingSetupTransaction(IWalletTransactionHandler wa
                 coldPubKeyHash = new BitcoinWitPubKeyAddress(coldWalletAddress, wallet.Network).Hash.AsKeyId();
                 destination = ColdStakingScriptTemplate.Instance.GenerateScriptPubKey(hotPubKeyHash, coldPubKeyHash);
 
-                if(payToScript)
+                if (payToScript)
                 {
                     HdAddress address = coldAddress ?? hotAddress;
                     address.RedeemScript = destination;
@@ -382,7 +382,7 @@ internal Transaction GetColdStakingSetupTransaction(IWalletTransactionHandler wa
             }
 
             // Only normal accounts should be allowed.
-            if (!this.GetAccounts(walletName).Any(a => a.Name == walletAccount))
+            if (this.GetAccounts(walletName).All(a => a.Name != walletAccount))
             {
                 this.logger.LogTrace("(-)[COLDSTAKE_ACCOUNT_NOT_FOUND]");
                 throw new WalletException($"Can't find wallet account '{walletAccount}'.");
@@ -403,20 +403,22 @@ internal Transaction GetColdStakingSetupTransaction(IWalletTransactionHandler wa
             {
                 // In the case of P2SH and P2WSH, to avoid the possibility of lose of funds
                 // we add an opreturn with the hot and cold key hashes to the setup transaction
-                // this will allow a user to recreate the redeem script of the output in case they lose 
-                // access to one of the keys. 
-                // The special marker will help a wallet that is tracking cold staking accounts to monitor 
-                // the hot and cold keys, if a special marker is found then the keys are in the opreturn are checked 
+                // this will allow a user to recreate the redeem script of the output in case they lose
+                // access to one of the keys.
+                // The special marker will help a wallet that is tracking cold staking accounts to monitor
+                // the hot and cold keys, if a special marker is found then the keys are in the opreturn are checked
                 // against the current wallet, if found and validated the wallet will track that ScriptPubKey
 
                 var opreturnKeys = new List<byte>();
                 opreturnKeys.AddRange(hotPubKeyHash.ToBytes());
                 opreturnKeys.AddRange(coldPubKeyHash.ToBytes());
-              
+
                 context.OpReturnRawData = opreturnKeys.ToArray();
-                //context.OpReturnAmount = Money.Satoshis(1); // mandatory fee must be paid.
-                 
-                // The P2SH and P2WSH hide the cold stake keys in the script hash so the wallet cannot track 
+                var template = this.network.StandardScriptsRegistry.GetScriptTemplates.OfType<TxNullDataTemplate>().First();
+                if (template.MinRequiredSatoshiFee > 0)
+                    context.OpReturnAmount = Money.Satoshis(template.MinRequiredSatoshiFee); // mandatory fee must be paid.
+
+                // The P2SH and P2WSH hide the cold stake keys in the script hash so the wallet cannot track
                 // the ouputs based on the derived keys when the trx is subbmited to the network.
                 // So we add the output script manually.
             }
@@ -611,7 +613,7 @@ public override void TransactionFoundInternal(Script script, Func<HdAccount, boo
         /// <summary>
         /// The purpose of this method is to try to identify the P2SH and P2WSH that are coldstake outputs for this wallet
         /// We look for an opreturn script that is created when seting up a P2SH and P2WSH cold stake trx
-        /// if we find any then try to find the keys and track the script before calling in to the main wallet.  
+        /// if we find any then try to find the keys and track the script before calling in to the main wallet.
         /// </summary>
         /// <inheritdoc/>
         public override bool ProcessTransaction(Transaction transaction, int? blockHeight = null, Block block = null, bool isPropagated = true)
@@ -628,7 +630,7 @@ public override bool ProcessTransaction(Transaction transaction, int? blockHeigh
                         if (data[0].Length == 40)
                         {
                             HdAddress address = null;
-                            
+
                             Span<byte> span = data[0].AsSpan();
                             var hotPubKey = new KeyId(span.Slice(0, 20).ToArray());
                             var coldPubKey = new KeyId(span.Slice(20, 20).ToArray());
@@ -642,11 +644,11 @@ public override bool ProcessTransaction(Transaction transaction, int? blockHeigh
                                 // Find the type of script for the opreturn (P2SH or P2WSH)
                                 foreach (TxOut utxoInner in transaction.Outputs)
                                 {
-                                    if(utxoInner.ScriptPubKey == destination.Hash.ScriptPubKey)
+                                    if (utxoInner.ScriptPubKey == destination.Hash.ScriptPubKey)
                                     {
-                                        if (!this.scriptToAddressLookup.TryGetValue(destination.Hash.ScriptPubKey,out HdAddress _))
+                                        if (!this.scriptToAddressLookup.TryGetValue(destination.Hash.ScriptPubKey, out HdAddress _))
                                             this.scriptToAddressLookup[destination.Hash.ScriptPubKey] = address;
-                                        
+
                                         break;
                                     }
 
@@ -673,9 +675,9 @@ protected override void AddAddressToIndex(HdAddress address)
         {
             base.AddAddressToIndex(address);
 
-            if(address.RedeemScript != null)
+            if (address.RedeemScript != null)
             {
-                // The redeem script has no indication on the script type (P2SH or P2WSH), 
+                // The redeem script has no indication on the script type (P2SH or P2WSH),
                 // so we track both, add both to the indexer then.
 
                 if (!this.scriptToAddressLookup.TryGetValue(address.RedeemScript.Hash.ScriptPubKey, out HdAddress _))
@@ -686,4 +688,4 @@ protected override void AddAddressToIndex(HdAddress address)
             }
         }
     }
-}
+}

src/Blockcore.Features.ColdStaking/Controllers/ColdStakingWalletRPCController.cs

@@ -1,6 +1,7 @@
 using Blockcore.Consensus;
 using Blockcore.Features.BlockStore;
 using Blockcore.Features.Wallet;
+using Blockcore.Features.Wallet.Controllers;
 using Blockcore.Features.Wallet.Interfaces;
 using Blockcore.Interfaces;
 using Microsoft.AspNetCore.Mvc;

src/Blockcore.Features.Consensus.Tests/Rules/CommonRules/PosCoinViewRuleTest.cs

@@ -68,7 +68,7 @@ private async Task<ConsensusManager> CreateConsensusManagerAsync(Dictionary<OutP
                 new Mock<IPeerBanning>().Object, initialBlockDownloadState, this.ChainIndexer, new Mock<IBlockPuller>().Object, new Mock<IBlockStore>().Object,
                 new Mock<IConnectionManager>().Object, new Mock<INodeStats>().Object, new Mock<INodeLifetime>().Object, this.consensusSettings, this.dateTimeProvider.Object);
 
-                // Mock the coinviews "FetchCoinsAsync" method. We will use the "unspentOutputs" dictionary to track spendable outputs.
+            // Mock the coinviews "FetchCoinsAsync" method. We will use the "unspentOutputs" dictionary to track spendable outputs.
             this.coinView.Setup(d => d.FetchCoins(It.IsAny<OutPoint[]>()))
                 .Returns((OutPoint[] txIds) =>
                 {
@@ -106,7 +106,7 @@ private async Task<ConsensusManager> CreateConsensusManagerAsync(Dictionary<OutP
             {
                 Flags = BlockFlag.BLOCK_PROOF_OF_STAKE,
                 StakeModifierV2 = 0,
-                StakeTime = (this.ChainIndexer.Tip.Header.Time + 60) & ~PosConsensusOptions.StakeTimestampMask
+                StakeTime = (this.ChainIndexer.Tip.Header.Time + 60) & ~this.network.Consensus.ProofOfStakeTimestampMask
             });
 
             // Since we are mocking the chainState ensure that the BlockStoreTip returns a usable value.
@@ -142,7 +142,6 @@ public async Task PosCoinViewRuleFailsAsync()
 
             ConsensusManager consensusManager = await this.CreateConsensusManagerAsync(unspentOutputs);
 
-
             // The keys used by miner 1 and miner 2.
             var minerKey1 = new Key();
             var minerKey2 = new Key();
@@ -166,13 +165,13 @@ public async Task PosCoinViewRuleFailsAsync()
             // Create a previous transaction with scriptPubKey outputs.
             Transaction prevTransaction = this.network.CreateTransaction();
 
-            uint blockTime = (this.ChainIndexer.Tip.Header.Time + 60) & ~PosConsensusOptions.StakeTimestampMask;
+            uint blockTime = (this.ChainIndexer.Tip.Header.Time + 60) & ~this.network.Consensus.ProofOfStakeTimestampMask;
 
             // To avoid violating the transaction timestamp consensus rule
             // we need to ensure that the transaction used for the coinstake's
             // input occurs well before the block time (as the coinstake time
             // is set to the block time)
-            if(prevTransaction is IPosTransactionWithTime posTrx)
+            if (prevTransaction is IPosTransactionWithTime posTrx)
                 posTrx.Time = blockTime - 100;
 
             // Coins sent to miner 2.

src/Blockcore.Features.Consensus/Rules/CommonRules/PosTimeMaskRule.cs

@@ -71,7 +71,7 @@ public override Task RunAsync(RuleContext context)
         /// <returns><c>true</c> if block timestamp is equal to transaction timestamp, <c>false</c> otherwise.</returns>
         private bool CheckCoinStakeTimestamp(long blockTime)
         {
-            return (blockTime & PosConsensusOptions.StakeTimestampMask) == 0;
+            return (blockTime & this.Parent.Network.Consensus.ProofOfStakeTimestampMask) == 0;
         }
     }
 }

src/Blockcore.Features.Consensus/Rules/ProvenHeaderRules/ProvenHeaderCoinstakeRule.cs

@@ -178,7 +178,7 @@ private void CheckHeaderAndCoinstakeTimes(ProvenBlockHeader header)
                 }
             }
 
-            if ((header.Time & PosConsensusOptions.StakeTimestampMask) != 0)
+            if ((header.Time & this.Parent.Network.Consensus.ProofOfStakeTimestampMask) != 0)
             {
                 this.Logger.LogTrace("(-)[BAD_TIME]");
                 ConsensusErrors.StakeTimeViolation.Throw();

src/Blockcore.Features.Consensus/Rules/UtxosetRules/CheckPosUtxosetRule.cs

@@ -12,7 +12,7 @@ namespace Blockcore.Features.Consensus.Rules.UtxosetRules
     /// <summary>
     /// Proof of stake override for the coinview rules - BIP68, MaxSigOps and BlockReward checks.
     /// </summary>
-    public sealed class CheckPosUtxosetRule : CheckUtxosetRule
+    public class CheckPosUtxosetRule : CheckUtxosetRule
     {
         /// <summary>Provides functionality for checking validity of PoS blocks.</summary>
         private IStakeValidator stakeValidator;
@@ -21,7 +21,7 @@ public sealed class CheckPosUtxosetRule : CheckUtxosetRule
         private IStakeChain stakeChain;
 
         /// <summary>The consensus of the parent Network.</summary>
-        private IConsensus consensus;
+        protected IConsensus consensus;
 
         /// <inheritdoc />
         public override void Initialize()
@@ -203,7 +203,7 @@ public override Money GetProofOfWorkReward(int height)
         /// </summary>
         /// <param name="height">Target block height.</param>
         /// <returns>Miner's coin stake reward.</returns>
-        public Money GetProofOfStakeReward(int height)
+        public virtual Money GetProofOfStakeReward(int height)
         {
             if (this.IsPremine(height))
                 return this.consensus.PremineReward;

src/Blockcore.Features.Consensus/StakeValidator.cs

@@ -167,7 +167,7 @@ public Target GetNextTargetRequired(IStakeChain stakeChain, ChainedHeader chaine
             }
 
             // This is used in tests to allow quickly mining blocks.
-            if (!proofOfStake && consensus.PowNoRetargeting) 
+            if (!proofOfStake && consensus.PowNoRetargeting)
             {
                 this.logger.LogTrace("(-)[NO_POW_RETARGET]:'{0}'", lastPowPosBlock.Header.Bits);
                 return lastPowPosBlock.Header.Bits;
@@ -308,11 +308,6 @@ public bool CheckStakeKernelHash(PosRuleContext context, uint headerBits, uint25
             // Base target.
             BigInteger target = new Target(headerBits).ToBigInteger();
 
-            // TODO: Investigate:
-            // The POS protocol should probably put a limit on the max amount that can be staked
-            // not a hard limit but a limit that allow any amount to be staked with a max weight value.
-            // the max weight should not exceed the max uint256 array size (array size = 32).
-
             // Weighted target.
             long valueIn = stakingCoins.Coins.TxOut.Value.Satoshi;
             BigInteger weight = BigInteger.ValueOf(valueIn);
@@ -326,7 +321,8 @@ public bool CheckStakeKernelHash(PosRuleContext context, uint headerBits, uint25
             {
                 var serializer = new BitcoinStream(ms, true);
                 serializer.ReadWrite(prevStakeModifier);
-                serializer.ReadWrite(stakingCoins.Coins.Time);
+                if (this.network.Consensus.PosUseTimeFieldInKernalHash) // old posv3 time field
+                    serializer.ReadWrite(stakingCoins.Coins.Time);
                 serializer.ReadWrite(prevout.Hash);
                 serializer.ReadWrite(prevout.N);
                 serializer.ReadWrite(transactionTime);
@@ -358,13 +354,6 @@ public bool VerifySignature(UnspentOutput coin, Transaction txTo, int txToInN, S
 
             TxIn input = txTo.Inputs[txToInN];
 
-            //if (input.PrevOut.N >= coin.Outputs.Length)
-            //{
-            //    this.logger.LogTrace("(-)[OUTPUT_INCORRECT_LENGTH]");
-            //    return false;
-            //}
-
-            //if (input.PrevOut.Hash != coin.TransactionId)
             if (input.PrevOut.Hash != coin.OutPoint.Hash)
             {
                 this.logger.LogTrace("(-)[INCORRECT_TX]");
@@ -486,5 +475,4 @@ public bool CheckStakeSignature(BlockSignature signature, uint256 blockHash, Tra
             return verifyRes;
         }
     }
-}
-
+}

src/Blockcore.Features.MemoryPool/MempoolPersistence.cs

@@ -158,7 +158,7 @@ public override int GetHashCode()
     /// <summary>
     /// Object used for persisting memory pool transactions.
     /// </summary>
-    internal class MempoolPersistence : IMempoolPersistence
+    public class MempoolPersistence : IMempoolPersistence
     {
         /// <summary>Current memory pool version number for persistence.</summary>
         public const ulong MempoolDumpVersion = 0;
@@ -328,4 +328,4 @@ internal IEnumerable<MempoolPersistenceEntry> LoadFromStream(Network network, St
             return toReturn;
         }
     }
-}
+}

src/Blockcore.Features.MemoryPool/MempoolValidator.cs

@@ -76,7 +76,7 @@ public class MempoolValidator : IMempoolValidator
         public const bool DefaultPermitBareMultisig = true;
 
         /// <summary>Maximum age of our tip in seconds for us to be considered current for fee estimation.</summary>
-        private const int MaxFeeEstimationTipAge = 3 * 60 * 60;
+        public const int MaxFeeEstimationTipAge = 3 * 60 * 60;
 
         /// <summary>A lock for managing asynchronous access to memory pool.</summary>
         private readonly MempoolSchedulerLock mempoolLock;