Get rid of prefix logger and its dependency on nlog

Author: dangershony

src/Blockcore.ruleset

@@ -5,6 +5,7 @@
     <Description Resource="MinimumRecommendedRules_Description" />
   </Localization>
   <Rules AnalyzerId="Microsoft.Analyzers.ManagedCodeAnalysis" RuleNamespace="Microsoft.Rules.Managed">
+    <Rule Id="SA0001" Action="None" />
     <Rule Id="CS0618" Action="Info" />
     <Rule Id="CA1001" Action="Warning" />
     <Rule Id="CA1009" Action="Warning" />

src/Blockcore/BlockPulling/BlockPullerBehavior.cs

@@ -117,7 +117,7 @@ public BlockPullerBehavior(IBlockPuller blockPuller, IInitialBlockDownloadState
 
             this.blockPuller = blockPuller;
 
-            this.logger = loggerFactory.CreateLogger(this.GetType().FullName, $"[{this.GetHashCode():x}] ");
+            this.logger = loggerFactory.CreateLogger(this.GetType().FullName);
             this.loggerFactory = loggerFactory;
         }
 

src/Blockcore/Connection/ConnectionManagerBehavior.cs

@@ -38,7 +38,7 @@ public class ConnectionManagerBehavior : NetworkPeerBehavior, IConnectionManager
 
         public ConnectionManagerBehavior(IConnectionManager connectionManager, ILoggerFactory loggerFactory)
         {
-            this.logger = loggerFactory.CreateLogger(this.GetType().FullName, $"[{this.GetHashCode():x}] ");
+            this.logger = loggerFactory.CreateLogger(this.GetType().FullName);
             this.infoLogger = loggerFactory.CreateLogger(this.GetType().FullName);
             this.loggerFactory = loggerFactory;
 

src/Blockcore/Connection/DropNodesBehaviour.cs

@@ -34,7 +34,7 @@ public class DropNodesBehaviour : NetworkPeerBehavior
 
         public DropNodesBehaviour(ChainIndexer chainIndexer, IConnectionManager connectionManager, ILoggerFactory loggerFactory)
         {
-            this.logger = loggerFactory.CreateLogger(this.GetType().FullName, $"[{this.GetHashCode():x}] ");
+            this.logger = loggerFactory.CreateLogger(this.GetType().FullName);
             this.loggerFactory = loggerFactory;
 
             this.chainIndexer = chainIndexer;

src/Blockcore/Consensus/ConsensusManagerBehavior.cs

@@ -84,7 +84,7 @@ public ConsensusManagerBehavior(ChainIndexer chainIndexer, IInitialBlockDownload
             this.asyncLock = new AsyncLock();
             this.bestSentHeaderLock = new object();
 
-            this.logger = loggerFactory.CreateLogger(this.GetType().FullName, $"[{this.GetHashCode():x}] ");
+            this.logger = loggerFactory.CreateLogger(this.GetType().FullName);
         }
 
         /// <summary>Presents cached headers to <see cref="Consensus.ConsensusManager"/> from the cache if any and removes consumed from the cache.</summary>

src/Blockcore/P2P/Peer/NetworkPeer.cs

@@ -352,7 +352,7 @@ public NetworkPeer(IPEndPoint peerEndPoint,
 
             this.Connection = networkPeerFactory.CreateNetworkPeerConnection(this, client, this.ProcessMessageAsync);
 
-            this.logger = loggerFactory.CreateLogger(this.GetType().FullName, $"[{this.Connection.Id}-{peerEndPoint}] ");
+            this.logger = loggerFactory.CreateLogger(this.GetType().FullName);
         }
 
         /// <summary>
@@ -382,7 +382,7 @@ public NetworkPeer(IPEndPoint peerEndPoint,
         {
             this.Connection = networkPeerFactory.CreateNetworkPeerConnection(this, client, this.ProcessMessageAsync);
 
-            this.logger = loggerFactory.CreateLogger(this.GetType().FullName, $"[{this.Connection.Id}-{peerEndPoint}] ");
+            this.logger = loggerFactory.CreateLogger(this.GetType().FullName);
 
             this.logger.LogDebug("Connected to peer '{0}'.", this.PeerEndPoint);
 

src/Blockcore/P2P/Peer/NetworkPeerConnection.cs

@@ -99,7 +99,7 @@ public NetworkPeerConnection(Network network, INetworkPeer peer, TcpClient clien
             this.loggerFactory = loggerFactory;
             this.payloadProvider = payloadProvider;
             this.asyncProvider = Guard.NotNull(asyncProvider, nameof(asyncProvider));
-            this.logger = this.loggerFactory.CreateLogger(this.GetType().FullName, $"[{clientId}-{peer.PeerEndPoint}] ");
+            this.logger = this.loggerFactory.CreateLogger(this.GetType().FullName);
 
             this.network = network;
             this.dateTimeProvider = dateTimeProvider;
@@ -172,7 +172,7 @@ private async Task ReceiveMessagesAsync()
         /// <exception cref="OperationCanceledException">Thrown when the connection attempt was aborted.</exception>
         public async Task ConnectAsync(IPEndPoint endPoint, CancellationToken cancellation)
         {
-            this.logger = this.loggerFactory.CreateLogger(this.GetType().FullName, $"[{this.Id}-{endPoint}] ");
+            this.logger = this.loggerFactory.CreateLogger(this.GetType().FullName);
 
             try
             {

src/Blockcore/P2P/Peer/NetworkPeerServer.cs

@@ -91,7 +91,7 @@ public NetworkPeerServer(Network network,
             IPeerAddressManager peerAddressManager,
             IDateTimeProvider dateTimeProvider)
         {
-            this.logger = loggerFactory.CreateLogger(this.GetType().FullName, $"[{localEndPoint}] ");
+            this.logger = loggerFactory.CreateLogger(this.GetType().FullName);
             this.signals = asyncProvider.Signals;
             this.networkPeerFactory = networkPeerFactory;
             this.networkPeerDisposer = new NetworkPeerDisposer(loggerFactory, asyncProvider);

src/Blockcore/P2P/PeerAddressManagerBehaviour.cs

@@ -57,7 +57,7 @@ public PeerAddressManagerBehaviour(IDateTimeProvider dateTimeProvider, IPeerAddr
             Guard.NotNull(peerAddressManager, nameof(loggerFactory));
 
             this.dateTimeProvider = dateTimeProvider;
-            this.logger = loggerFactory.CreateLogger(this.GetType().FullName, $"[{this.GetHashCode():x}] ");
+            this.logger = loggerFactory.CreateLogger(this.GetType().FullName);
             this.loggerFactory = loggerFactory;
             this.peerBanning = peerBanning;
             this.Mode = PeerAddressManagerBehaviourMode.AdvertiseDiscover;

src/Blockcore/P2P/Protocol/Behaviors/EnforcePeerVersionCheckBehavior.cs

@@ -51,7 +51,7 @@ public EnforcePeerVersionCheckBehavior(ChainIndexer chainIndexer,
             this.NodeSettings = nodeSettings;
             this.Network = network;
             this.LoggerFactory = loggerFactory;
-            this.Logger = loggerFactory.CreateLogger(this.GetType().FullName, $"[{this.GetHashCode():x}] ");
+            this.Logger = loggerFactory.CreateLogger(this.GetType().FullName);
         }
 
         protected Task OnMessageReceivedAsync(INetworkPeer peer, IncomingMessage message)