Skip to content

Commit 3f0b92d

Browse files
authored
Minor improvement to the NodeBuilder for test node. (#296)
- Ensures no DRY. - X42 should not use the WatchOnlyWallet, not being maintained or used. - Update the changelog.
1 parent 69dfb03 commit 3f0b92d

2 files changed

Lines changed: 19 additions & 7 deletions

File tree

CHANGELOG.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
## (2021-03-09)
2+
3+
* Add IMPLX MainNet SeedNodes and CheckpointInfo (#283) ([8595042](https://github.com/block-core/blockcore/commit/8595042)), closes [#283](https://github.com/block-core/blockcore/issues/283)
4+
* Add upload of artifact to the build (#292) ([6710591](https://github.com/block-core/blockcore/commit/6710591)), closes [#292](https://github.com/block-core/blockcore/issues/292) [#291](https://github.com/block-core/blockcore/issues/291)
5+
* Added support for xRhodium (XRC) (#286) ([6430223](https://github.com/block-core/blockcore/commit/6430223)), closes [#286](https://github.com/block-core/blockcore/issues/286)
6+
* Adding HomeCoin Network (#289) ([129c67d](https://github.com/block-core/blockcore/commit/129c67d)), closes [#289](https://github.com/block-core/blockcore/issues/289)
7+
* bump version ([b8d16e9](https://github.com/block-core/blockcore/commit/b8d16e9))
8+
* Disable the request logging to avoid logging password and other request data (#287) ([6d8813e](https://github.com/block-core/blockcore/commit/6d8813e)), closes [#287](https://github.com/block-core/blockcore/issues/287)
9+
* Feature/upload artifact on workflow (#293) ([8aefa13](https://github.com/block-core/blockcore/commit/8aefa13)), closes [#293](https://github.com/block-core/blockcore/issues/293) [#291](https://github.com/block-core/blockcore/issues/291)
10+
* Launch setting names should use the technical chain name (#294) ([2f1b241](https://github.com/block-core/blockcore/commit/2f1b241)), closes [#294](https://github.com/block-core/blockcore/issues/294)
11+
* Resolve PR comments from initial PR on HomeCoin (#295) ([69dfb03](https://github.com/block-core/blockcore/commit/69dfb03)), closes [#295](https://github.com/block-core/blockcore/issues/295)
12+
13+
14+
115
## (2021-02-19)
216

317
* Add checkpoints for City Chain network ([ef16368](https://github.com/block-core/blockcore/commit/ef16368))

src/Node/Blockcore.Node/NodeBuilder.cs

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,27 +34,25 @@ public static IFullNodeBuilder Create(string chain, NodeSettings settings)
3434
switch (chain)
3535
{
3636
case "BTC":
37+
case "XRC":
3738
nodeBuilder.UsePowConsensus().AddMining().UseWallet();
3839
break;
39-
case "X42":
40-
nodeBuilder.UsePosConsensus().AddPowPosMining().UseColdStakingWallet().UseWatchOnlyWallet();
41-
break;
4240
case "X1":
43-
nodeBuilder.UseX1Consensus().UseColdStakingWallet(); ;
41+
nodeBuilder.UseX1Consensus().UseColdStakingWallet();
4442
break;
43+
case "AMS":
44+
case "X42":
4545
case "BCP":
4646
case "CITY":
4747
case "STRAT":
4848
case "RUTA":
4949
case "EXOS":
5050
case "XDS":
51+
case "XLR":
5152
case "IMPLX":
5253
case "HOME":
5354
nodeBuilder.UsePosConsensus().AddPowPosMining().UseColdStakingWallet();
5455
break;
55-
case "XRC":
56-
nodeBuilder.UsePowConsensus().AddMining().UseWallet();
57-
break;
5856
}
5957

6058
return nodeBuilder;

0 commit comments

Comments
 (0)