Improve performance by avoiding methods

- Avoid calling ToHex and ToString (ID) in the constructor.
- Calling the ToString to get ID only in the get method, which means it will only be called during serialization or upon request.
- Related to #269

Author: sondreb

src/Blockcore/Connection/Broadcasting/BroadcastTransactionStateChanedEntry.cs

@@ -7,12 +7,13 @@ namespace Blockcore.Connection.Broadcasting
 {
     public class BroadcastTransactionStateChanedEntry
     {
-        [JsonIgnore]
+        [JsonIgnore] // The "Transaction" cannot serialize for Web Socket.
         public Transaction Transaction { get; }
 
-        public string TransactionHex { get; }
-
-        public string TransactionId { get; }
+        /// <summary>
+        /// Makes the transaction ID available for Web Socket consumers.
+        /// </summary>
+        public string TransactionId { get { return this.Transaction.ToString(); } }
 
         [JsonConverter(typeof(StringEnumConverter))]
         public TransactionBroadcastState TransactionBroadcastState { get; set; }
@@ -24,8 +25,6 @@ public class BroadcastTransactionStateChanedEntry
         public BroadcastTransactionStateChanedEntry(Transaction transaction, TransactionBroadcastState transactionBroadcastState, string errorMessage)
         {
             this.Transaction = transaction ?? throw new ArgumentNullException(nameof(transaction));
-            this.TransactionHex = transaction.ToHex();
-            this.TransactionId = transaction.ToString();
             this.TransactionBroadcastState = transactionBroadcastState;
             this.ErrorMessage = (errorMessage == null) ? string.Empty : errorMessage;
         }

src/Blockcore/EventBus/CoreEvents/TransactionReceived.cs

@@ -11,18 +11,17 @@ namespace Blockcore.EventBus.CoreEvents
     /// <seealso cref="EventBase" />
     public class TransactionReceived : EventBase
     {
-        [JsonIgnore]
+        [JsonIgnore] // The "Transaction" cannot serialize for Web Socket.
         public Transaction ReceivedTransaction { get; }
 
-        public string TransactionHex { get; set; }
-
-        public string TransactionId { get; set; }
+        /// <summary>
+        /// Makes the transaction ID available for Web Socket consumers.
+        /// </summary>
+        public string TransactionId { get { return this.ReceivedTransaction.ToString(); } }
 
         public TransactionReceived(Transaction receivedTransaction)
         {
             this.ReceivedTransaction = receivedTransaction;
-            this.TransactionHex = receivedTransaction.ToHex();
-            this.TransactionId = receivedTransaction.ToString();
         }
     }
 }

src/Features/Blockcore.Features.Wallet/Events/TransactionFound.cs

@@ -14,18 +14,17 @@ namespace Blockcore.Features.Wallet.Events
     /// <seealso cref="Blockcore.EventBus.EventBase" />
     public class TransactionFound : EventBase
     {
-        [JsonIgnore]
+        [JsonIgnore] // The "Transaction" cannot serialize for Web Socket.
         public Transaction FoundTransaction { get; }
 
-        public string TransactionHex { get; set; }
-
-        public string TransactionId { get; set; }
+        /// <summary>
+        /// Makes the transaction ID available for Web Socket consumers.
+        /// </summary>
+        public string TransactionId { get { return this.FoundTransaction.ToString(); } }
 
         public TransactionFound(Transaction foundTransaction)
         {
             this.FoundTransaction = foundTransaction;
-            this.TransactionHex = foundTransaction.ToHex();
-            this.TransactionId = foundTransaction.ToString();
         }
     }
 }