fixes #197 (#198)

MithrilMan · web-flow · commit bd62c4344e7a · 2020-07-31T00:51:04.000+01:00
diff --git a/src/Features/Blockcore.Features.Consensus/Rules/CommonRules/CheckPowTransactionRule.cs b/src/Features/Blockcore.Features.Consensus/Rules/CommonRules/CheckPowTransactionRule.cs
@@ -86,13 +86,11 @@ public virtual void CheckTransaction(Network network, ConsensusOptions options,
             var inOutPoints = new HashSet<OutPoint>();
             foreach (TxIn txin in tx.Inputs)
             {
-                if (inOutPoints.Contains(txin.PrevOut))
+                if (!inOutPoints.Add(txin.PrevOut))
                 {
                     this.Logger.LogTrace("(-)[TX_DUP_INPUTS]");
                     ConsensusErrors.BadTransactionDuplicateInputs.Throw();
                 }
-
-                inOutPoints.Add(txin.PrevOut);
             }
 
             if (tx.IsCoinBase)

Original file line number	Diff line number	Diff line change
`@@ -86,13 +86,11 @@ public virtual void CheckTransaction(Network network, ConsensusOptions options,`
`86`	`86`	`var inOutPoints = new HashSet<OutPoint>();`
`87`	`87`	`foreach (TxIn txin in tx.Inputs)`
`88`	`88`	`{`
`89`		`- if (inOutPoints.Contains(txin.PrevOut))`
	`89`	`+ if (!inOutPoints.Add(txin.PrevOut))`
`90`	`90`	`{`
`91`	`91`	`this.Logger.LogTrace("(-)[TX_DUP_INPUTS]");`
`92`	`92`	`ConsensusErrors.BadTransactionDuplicateInputs.Throw();`
`93`	`93`	`}`
`94`		`-`
`95`		`- inOutPoints.Add(txin.PrevOut);`
`96`	`94`	`}`
`97`	`95`
`98`	`96`	`if (tx.IsCoinBase)`