Fix failing tests

Author: dangershony

src/Blockcore/Controllers/NodeController.cs

@@ -260,13 +260,13 @@ public IActionResult GetBlockHeader([FromQuery] string hash, bool isJsonFormat =
         /// <remarks>Requires txindex=1, otherwise only txes that spend or create UTXOs for a wallet can be returned.</remarks>
         [Route("getrawtransaction")]
         [HttpGet]
-        public async Task<IActionResult> GetRawTransactionAsync([FromQuery] string txid, bool verbose = false, string blockHash = null)
+        public async Task<IActionResult> GetRawTransactionAsync([FromQuery] string trxid, bool verbose = false, string blockHash = null)
         {
             try
             {
-                Guard.NotEmpty(txid, nameof(txid));
+                Guard.NotEmpty(trxid, nameof(trxid));
 
-                if (!uint256.TryParse(txid, out uint256 trxid))
+                if (!uint256.TryParse(trxid, out uint256 trxhash))
                 {
                     throw new ArgumentException(nameof(trxid));
                 }
@@ -278,7 +278,7 @@ public async Task<IActionResult> GetRawTransactionAsync([FromQuery] string txid,
                 }
 
                 // Special exception for the genesis block coinbase transaction.
-                if (trxid == this.network.GetGenesis().GetMerkleRoot().Hash)
+                if (trxhash == this.network.GetGenesis().GetMerkleRoot().Hash)
                 {
                     throw new Exception("The genesis block coinbase is not considered an ordinary transaction and cannot be retrieved.");
                 }
@@ -289,12 +289,12 @@ public async Task<IActionResult> GetRawTransactionAsync([FromQuery] string txid,
                 if (hash == null)
                 {
                     // Look for the transaction in the mempool, and if not found, look in the indexed transactions.
-                    trx = (this.pooledTransaction == null ? null : await this.pooledTransaction.GetTransaction(trxid).ConfigureAwait(false)) ??
-                          this.blockStore.GetTransactionById(trxid);
+                    trx = (this.pooledTransaction == null ? null : await this.pooledTransaction.GetTransaction(trxhash).ConfigureAwait(false)) ??
+                          this.blockStore.GetTransactionById(trxhash);
 
                     if (trx == null)
                     {
-                        throw new Exception("No such mempool transaction. Use -txindex to enable blockchain transaction queries.");
+                        return this.Json(null);
                     }
                 }
                 else
@@ -307,7 +307,7 @@ public async Task<IActionResult> GetRawTransactionAsync([FromQuery] string txid,
                         throw new Exception("Block hash not found.");
                     }
 
-                    trx = chainedHeaderBlock.Block.Transactions.SingleOrDefault(t => t.GetHash() == trxid);
+                    trx = chainedHeaderBlock.Block.Transactions.SingleOrDefault(t => t.GetHash() == trxhash);
 
                     if (trx == null)
                     {
@@ -317,7 +317,7 @@ public async Task<IActionResult> GetRawTransactionAsync([FromQuery] string txid,
 
                 if (verbose)
                 {
-                    ChainedHeader block = chainedHeaderBlock != null ? chainedHeaderBlock.ChainedHeader : this.GetTransactionBlock(trxid);
+                    ChainedHeader block = chainedHeaderBlock != null ? chainedHeaderBlock.ChainedHeader : this.GetTransactionBlock(trxhash);
                     return this.Json(new TransactionVerboseModel(trx, this.network, block, this.chainState?.ConsensusTip));
                 }
                 else

src/Features/Blockcore.Features.Miner/Api/Controllers/StakingController.cs

@@ -86,7 +86,7 @@ public IActionResult GetStakingInfo()
         /// <returns>An <see cref="OkResult"/> object that produces a status code 200 HTTP response.</returns>
         [Route("startstaking")]
         [HttpPost]
-        public IActionResult StartStaking([FromBody]StartStakingRequest request)
+        public IActionResult StartStaking([FromBody] StartStakingRequest request)
         {
             Guard.NotNull(request, nameof(request));
 
@@ -190,7 +190,7 @@ public IActionResult StakingExpiry([FromBody] StakingExpiryRequest request)
         }
 
         [Route("getStakingNotExpired")]
-        [HttpPost]
+        [HttpGet]
         public IActionResult GetStakingNotExpired(StakingNotExpiredRequest request)
         {
             try

src/Features/Blockcore.Features.Wallet/Api/Controllers/WalletController.cs

@@ -804,7 +804,7 @@ public IActionResult SendTransaction([FromBody] SendTransactionRequest request)
         /// </summary>
         /// <returns>A JSON object containing information about the re sent transactions.</returns>
         [Route("resend-unconfirmed-transactions")]
-        [HttpPost]
+        [HttpGet]
         public IActionResult ResendUnconfirmedTransactions()
         {
             // checks the request is valid

src/Tests/Blockcore.Tests/Controllers/NodeControllerTest.cs

@@ -75,7 +75,8 @@ public NodeControllerTest()
             this.CreateNewController();
         }
 
-        private void CreateNewController() {
+        private void CreateNewController()
+        {
             this.controller = new NodeController(
                 this.chainIndexer,
                 this.chainState.Object,
@@ -254,11 +255,10 @@ public async Task GetTaskAsync_Verbose_ReturnsTransactionVerboseModelAsync()
             var txId = new uint256(12142124);
             this.pooledTransaction.Setup(p => p.GetTransaction(txId))
                 .ReturnsAsync(transaction);
-            var blockStore = new Mock<IBlockStore>();
-            blockStore.Setup(b => b.GetBlockIdByTransactionId(txId))
+            this.blockStore.Setup(b => b.GetBlockIdByTransactionId(txId))
                 .Returns(block.HashBlock);
             this.fullNode.Setup(f => f.NodeFeature<IBlockStore>(false))
-                .Returns(blockStore.Object);
+                .Returns(this.blockStore.Object);
             string txid = txId.ToString();
             bool verbose = true;