Skip to content

Commit faab7ff

Browse files
dangershonydangershony
authored
Remove all warnings from the solution (#243)
* delete ruleset and migrate to edditorconfig * Fix more warnings * Fix many warnings * Fix warnings on UI elements * From now on treat warnings as errors * fix warning * Fix rocks db proj reference name * Fix persistance to separate pow and pow * Fix unit tests
1 parent 0ce71d5 commit faab7ff

42 files changed

Lines changed: 491 additions & 1116 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/.editorconfig‎

Lines changed: 149 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,5 +38,154 @@ dotnet_naming_style.end_with_async.capitalization = pascal_case
3838
# SA1401: Fields should be private
3939
dotnet_diagnostic.SA1401.severity = none
4040

41+
# comments related
42+
dotnet_diagnostic.CS1591.severity = none
43+
dotnet_diagnostic.CS1574.severity = none
44+
dotnet_diagnostic.CS1584.severity = none
45+
dotnet_diagnostic.CS1723.severity = none
46+
dotnet_diagnostic.CS1570.severity = none
47+
dotnet_diagnostic.CS1571.severity = none
48+
dotnet_diagnostic.CS1572.severity = none
49+
dotnet_diagnostic.CS1570.severity = none
50+
dotnet_diagnostic.CS1587.severity = none
51+
dotnet_diagnostic.CS1580.severity = none
52+
dotnet_diagnostic.CSxxxx.severity = none
53+
54+
# migrated from rulset
55+
56+
57+
dotnet_diagnostic.CA1001.severity = warning
58+
dotnet_diagnostic.CA1009.severity = warning
59+
dotnet_diagnostic.CA1016.severity = warning
60+
dotnet_diagnostic.CA1033.severity = warning
61+
dotnet_diagnostic.CA1049.severity = warning
62+
dotnet_diagnostic.CA1060.severity = warning
63+
dotnet_diagnostic.CA1061.severity = warning
64+
dotnet_diagnostic.CA1063.severity = warning
65+
dotnet_diagnostic.CA1065.severity = warning
66+
dotnet_diagnostic.CA1301.severity = warning
67+
dotnet_diagnostic.CA1400.severity = warning
68+
dotnet_diagnostic.CA1401.severity = warning
69+
dotnet_diagnostic.CA1403.severity = warning
70+
dotnet_diagnostic.CA1404.severity = warning
71+
dotnet_diagnostic.CA1405.severity = warning
72+
dotnet_diagnostic.CA1410.severity = warning
73+
dotnet_diagnostic.CA1415.severity = warning
74+
dotnet_diagnostic.CA1821.severity = warning
75+
dotnet_diagnostic.CA1900.severity = warning
76+
dotnet_diagnostic.CA1901.severity = warning
77+
dotnet_diagnostic.CA2002.severity = warning
78+
dotnet_diagnostic.CA2100.severity = warning
79+
dotnet_diagnostic.CA2101.severity = warning
80+
dotnet_diagnostic.CA2108.severity = warning
81+
dotnet_diagnostic.CA2111.severity = warning
82+
dotnet_diagnostic.CA2112.severity = warning
83+
dotnet_diagnostic.CA2114.severity = warning
84+
dotnet_diagnostic.CA2116.severity = warning
85+
dotnet_diagnostic.CA2117.severity = warning
86+
dotnet_diagnostic.CA2122.severity = warning
87+
dotnet_diagnostic.CA2123.severity = warning
88+
dotnet_diagnostic.CA2124.severity = warning
89+
dotnet_diagnostic.CA2126.severity = warning
90+
dotnet_diagnostic.CA2131.severity = warning
91+
dotnet_diagnostic.CA2132.severity = warning
92+
dotnet_diagnostic.CA2133.severity = warning
93+
dotnet_diagnostic.CA2134.severity = warning
94+
dotnet_diagnostic.CA2137.severity = warning
95+
dotnet_diagnostic.CA2138.severity = warning
96+
dotnet_diagnostic.CA2140.severity = warning
97+
dotnet_diagnostic.CA2141.severity = warning
98+
dotnet_diagnostic.CA2146.severity = warning
99+
dotnet_diagnostic.CA2147.severity = warning
100+
dotnet_diagnostic.CA2149.severity = warning
101+
dotnet_diagnostic.CA2200.severity = warning
102+
dotnet_diagnostic.CA2202.severity = warning
103+
dotnet_diagnostic.CA2207.severity = warning
104+
dotnet_diagnostic.CA2212.severity = warning
105+
dotnet_diagnostic.CA2213.severity = warning
106+
dotnet_diagnostic.CA2214.severity = warning
107+
dotnet_diagnostic.CA2216.severity = warning
108+
dotnet_diagnostic.CA2220.severity = warning
109+
dotnet_diagnostic.CA2229.severity = warning
110+
dotnet_diagnostic.CA2231.severity = warning
111+
dotnet_diagnostic.CA2232.severity = warning
112+
dotnet_diagnostic.CA2235.severity = warning
113+
dotnet_diagnostic.CA2236.severity = warning
114+
dotnet_diagnostic.CA2237.severity = warning
115+
dotnet_diagnostic.CA2238.severity = warning
116+
dotnet_diagnostic.CA2240.severity = warning
117+
dotnet_diagnostic.CA2241.severity = warning
118+
dotnet_diagnostic.CA2242.severity = warning
119+
dotnet_diagnostic.CS0618.severity = suggestion
120+
dotnet_diagnostic.SA0001.severity = none
121+
dotnet_diagnostic.SA1003.severity = none
122+
dotnet_diagnostic.SA1008.severity = none
123+
dotnet_diagnostic.SA1009.severity = none
124+
dotnet_diagnostic.SA1012.severity = none
125+
dotnet_diagnostic.SA1013.severity = none
126+
dotnet_diagnostic.SA1100.severity = none
127+
dotnet_diagnostic.SA1108.severity = none
128+
dotnet_diagnostic.SA1110.severity = none
129+
dotnet_diagnostic.SA1111.severity = none
130+
dotnet_diagnostic.SA1116.severity = none
131+
dotnet_diagnostic.SA1117.severity = none
132+
dotnet_diagnostic.SA1119.severity = none
133+
dotnet_diagnostic.SA1124.severity = none
134+
dotnet_diagnostic.SA1127.severity = none
135+
dotnet_diagnostic.SA1128.severity = none
136+
dotnet_diagnostic.SA1131.severity = none
137+
dotnet_diagnostic.SA1139.severity = none
138+
dotnet_diagnostic.SA1201.severity = none
139+
dotnet_diagnostic.SA1202.severity = none
140+
dotnet_diagnostic.SA1203.severity = none
141+
dotnet_diagnostic.SA1204.severity = none
142+
dotnet_diagnostic.SA1214.severity = none
143+
dotnet_diagnostic.SA1216.severity = none
144+
dotnet_diagnostic.SA1217.severity = none
145+
dotnet_diagnostic.SA1300.severity = none
146+
dotnet_diagnostic.SA1402.severity = none
147+
dotnet_diagnostic.SA1407.severity = none
148+
dotnet_diagnostic.SA1413.severity = none
149+
dotnet_diagnostic.SA1501.severity = none
150+
dotnet_diagnostic.SA1502.severity = none
151+
dotnet_diagnostic.SA1503.severity = none
152+
dotnet_diagnostic.SA1512.severity = none
153+
dotnet_diagnostic.SA1515.severity = none
154+
dotnet_diagnostic.SA1520.severity = none
155+
# Documentation stuff that needs to be hanged to warning at some point.
156+
dotnet_diagnostic.SA1600.severity = none
157+
dotnet_diagnostic.SA1602.severity = none
158+
dotnet_diagnostic.SA1604.severity = none
159+
dotnet_diagnostic.SA1611.severity = none
160+
dotnet_diagnostic.SA1615.severity = none
161+
dotnet_diagnostic.SA1616.severity = none
162+
dotnet_diagnostic.SA1618.severity = none
163+
dotnet_diagnostic.SA1623.severity = none
164+
dotnet_diagnostic.SA1625.severity = none
165+
dotnet_diagnostic.SA1629.severity = none
166+
dotnet_diagnostic.SA1633.severity = none
167+
dotnet_diagnostic.SA1640.severity = none
168+
dotnet_diagnostic.SA1641.severity = none
169+
dotnet_diagnostic.SA1642.severity = none
170+
dotnet_diagnostic.SA1643.severity = none
171+
dotnet_diagnostic.SA1649.severity = none
172+
dotnet_diagnostic.SA1652.severity = none
173+
dotnet_diagnostic.SA1612.severity = none
174+
dotnet_diagnostic.SA1614.severity = none
175+
dotnet_diagnostic.SA1648.severity = none
176+
dotnet_diagnostic.SA1005.severity = none
177+
dotnet_diagnostic.SA1601.severity = none
178+
dotnet_diagnostic.SA1107.severity = none
179+
dotnet_diagnostic.SA1114.severity = none
180+
181+
# CS1658: Warning is overriding an error
182+
dotnet_diagnostic.CS1658.severity = none
183+
184+
# CS1573: Parameter has no matching param tag in the XML comment (but other parameters do)
185+
dotnet_diagnostic.CS1573.severity = none
186+
187+
# xUnit2013: Do not use equality check to check for collection size.
188+
dotnet_diagnostic.xUnit2013.severity = none
189+
41190
[*.{cs,vb}]
42191
dotnet_sort_system_directives_first = true

‎src/Blockcore.ruleset‎

Lines changed: 0 additions & 128 deletions
This file was deleted.

‎src/Blockcore.sln‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,7 @@ EndProject
7070
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Global", "Global", "{0C6FDCCE-6D75-441F-86FA-2AD177196BF8}"
7171
ProjectSection(SolutionItems) = preProject
7272
.editorconfig = .editorconfig
73-
Blockcore.ruleset = Blockcore.ruleset
7473
Directory.Build.props = Directory.Build.props
75-
None.ruleset = None.ruleset
7674
stylecop.json = stylecop.json
7775
test.runsettings = test.runsettings
7876
EndProjectSection

‎src/Blockcore/.editorconfig‎

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
# Editor configuration, see http://editorconfig.org
2+
3+
# todo: fix styling on the classes bellow
4+
5+
[ScriptEvaluationContext.cs]
6+
dotnet_analyzer_diagnostic.severity = none
7+
8+
[Script.cs]
9+
dotnet_analyzer_diagnostic.severity = none
10+
11+
[Transaction.cs]
12+
dotnet_analyzer_diagnostic.severity = none
13+
14+
[TransactionBuilder.cs]
15+
dotnet_analyzer_diagnostic.severity = none
16+
17+
[TransactionSignature.cs]
18+
dotnet_analyzer_diagnostic.severity = none
19+
20+
[StandardScriptTemplate.cs]
21+
dotnet_analyzer_diagnostic.severity = none
22+
23+
[IpExtensions.cs]
24+
dotnet_analyzer_diagnostic.severity = none
25+
26+
[ValidatedAddress.cs]
27+
dotnet_analyzer_diagnostic.severity = none
28+
29+
[Network.cs]
30+
dotnet_analyzer_diagnostic.severity = none
31+
32+
[ScriptReader.cs]
33+
dotnet_analyzer_diagnostic.severity = none
34+
35+
[NBitcoin/**.cs]
36+
dotnet_analyzer_diagnostic.severity = none
37+

‎src/Blockcore/Base/Deployments/BIP9Deployments.cs‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public class BIP9DeploymentsParameters
1616

1717
// 75% of 144 blocks
1818
public const long DefaultRegTestThreshold = 108;
19-
19+
2020
public BIP9DeploymentsParameters(string name, int bit, DateTimeOffset startTime, DateTimeOffset timeout, long threshold)
2121
{
2222
this.Bit = bit;
@@ -25,9 +25,9 @@ public BIP9DeploymentsParameters(string name, int bit, DateTimeOffset startTime,
2525
this.Threshold = threshold;
2626
this.Name = name.ToLower();
2727
}
28-
28+
2929
public BIP9DeploymentsParameters(string name, int bit, long startTime, long timeout, long threshold)
30-
: this(name, bit, (DateTimeOffset) Utils.UnixTimeToDateTime(startTime), Utils.UnixTimeToDateTime(timeout), threshold)
30+
: this(name, bit, (DateTimeOffset)Utils.UnixTimeToDateTime(startTime), Utils.UnixTimeToDateTime(timeout), threshold)
3131
{
3232
}
3333

@@ -53,13 +53,12 @@ public DateTimeOffset Timeout
5353
private set;
5454
}
5555

56-
public string Name
56+
public string Name
5757
{
5858
get;
5959
private set;
6060
}
6161

62-
6362
/// <summary>Specifies the activation threshold for this deployment. The BIP9 specification originally set the threshold at >=1916 blocks (95% of 2016),
6463
/// or >=1512 for testnet (75% of 2016). </summary>
6564
public long Threshold
@@ -68,4 +67,4 @@ public long Threshold
6867
private set;
6968
}
7069
}
71-
}
70+
}

‎src/Blockcore/Base/Deployments/BIP9DeploymentsArray.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ namespace Blockcore.Base.Deployments
1010
public class BIP9DeploymentFlags
1111
{
1212
public ScriptVerify ScriptFlags { get; set; }
13+
1314
public Transaction.LockTimeFlags LockTimeFlags { get; set; }
1415

1516
public BIP9DeploymentFlags()

‎src/Blockcore/Blockcore.csproj‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
<AssemblyName>Blockcore</AssemblyName>
77
<PackageId>Blockcore.Core</PackageId>
88
<GeneratePackageOnBuild>False</GeneratePackageOnBuild>
9-
<CodeAnalysisRuleSet>..\Blockcore.ruleset</CodeAnalysisRuleSet>
109
<IsPackable>true</IsPackable>
1110
</PropertyGroup>
1211

0 commit comments

Comments
 (0)