Move ProtocolVersion to the Consensus class#126
Merged
dangershony merged 6 commits intomasterfrom May 20, 2020
Merged
Conversation
sondreb
approved these changes
May 19, 2020
Member
sondreb
left a comment
sondreb
left a comment
There was a problem hiding this comment.
Overall very good change to get into the codebase. Did a quick look through the changes, not a deep review. Running all tests locally now and have done an initial verification that the City Node can connect to network.
| @@ -54,7 +54,7 @@ public interface INetworkPeer : IDisposable | |||
| /// <summary> | |||
| /// The negotiated protocol version (minimum of supported version between <see cref="MyVersion"/> and the <see cref="PeerVersion"/>). | |||
Member
There was a problem hiding this comment.
"See ref" in documentation is now wrong.
| } | ||
|
|
||
| #endregion | ||
| #endregion ICoinSelector Members |
Member
There was a problem hiding this comment.
Regions are evil, always removed them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea behind this PR is to make ProtocolVersion available per chain (right now versions of different chains are mixed together)
Also ProtocolVersion was defined in the Settings class which is incorrect as its a property of consensus the protocol.