Added fee for OP_RETURN data for x42.#139
Merged
dangershony merged 1 commit intoblock-core:masterfrom May 28, 2020
Merged
Conversation
dangershony
reviewed
May 28, 2020
|
|
||
| List<byte[]> opReturns = context.Transaction.Outputs.Select(o => o.ScriptPubKey.ToBytes(true)).Where(b => IsOpReturn(b)).ToList(); | ||
| Money transactionFees = context.Fees; | ||
| FeeRate OpReturnFeeRate = new FeeRate(((x42Consensus)this.network.Consensus).MinOpReturnFee); |
Member
There was a problem hiding this comment.
This is static you could create it in the constructor
dangershony
approved these changes
May 28, 2020
Member
dangershony
left a comment
dangershony
left a comment
There was a problem hiding this comment.
Very good implementation of the Transaction rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And cleanup.