Conversation
I see that you took away the non segwit address textbox (I wonder if we should keep it just in case? |
| public string Icon => "oi-pulse"; | ||
| public bool IsVisible => true; //hasWallets(); | ||
| public bool hasWallets() { | ||
| var walletManager = this.WalletManager as WalletManager; |
There was a problem hiding this comment.
I would actually iterate over wallets instead of checking the type.
|
when node syncs wallet seems to report its synced even though node is not synced I wonder if we should also look at IBD flag ( I can fix this later not urgent) |
| private void Submit() | ||
| { | ||
| ShowForm = false; | ||
| this.Alert = "Your wallet has now been created."; |
There was a problem hiding this comment.
No the view tx is not implemented yet, I still need to work out how I’m going to do it. I may disable this until I can get it working so we can push the other changes
There was a problem hiding this comment.
Display segwit address when segwit enabled
I see that you took away the non segwit address textbox (I wonder if we should keep it just in case?
Are there situations a none segwit address is needed even if segwit is enabled?
We can add this back in if necessary, I'll leave it as is for now.
| <span class="float-right"> | ||
| <a href="/docs/index.html" target="_blank">Open API</a> | ||
| <a href="/ws-ui/index.html" target="_blank>Web Socket</a> | ||
| <a href="/ws-ui/index.html" target="_blank">Web Socket</a> |
There was a problem hiding this comment.
Do we plan to show this? maybe as a modal or a new page (on a separate PR)
There was a problem hiding this comment.
I plan to revisit the layout at some point to add these links back in
|
@thecrypt0hunter check my changes and if you are fine with it we can push. |
|
I’ll check through tonight |
I've updated so that the syncing icon is based on the IBD flag. |
|
It's ready to push now @dangershony |
2 participants
Uh oh!
There was an error while loading. Please reload this page.