Merged
Conversation
sondreb
approved these changes
Jul 5, 2020
Member
sondreb
left a comment
sondreb
left a comment
There was a problem hiding this comment.
Great PR, looking forwarding to testing it out on some large wallets! This will be a good benefit for large stakers/miners, and for exchanges/integrators/Point-of-Sale and other solutions. Good work!
Contributor
|
Is it worth moving the old wallets to a backup or archive folder? |
Member
Author
|
closes #180 |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wallet db upgrade
This PR moves the wallets to use litedb instead of in memory json file.
The json file is still there but only holds derived addresses and is still named
[walletname].wallet.jsonWallet db files go in the folder
txdbformat[walletname].dbthe folder can be deleted in order to resync the wallet.Old wallet files are copied in to
[walletname].wallet.json.backupfiles and are not touched.To upgrade just start the node nothing else needs to be done, existing wallets will resync from genesis.