Skip to content

Fix wallet unit tests#213

Merged
dangershony merged 1 commit intoblock-core:masterfrom
xandronus:wallettest-fix
Nov 19, 2020
Merged

Fix wallet unit tests#213
dangershony merged 1 commit intoblock-core:masterfrom
xandronus:wallettest-fix

Conversation

@xandronus
Copy link
Copy Markdown
Contributor

Fixes #210

A couple of different issues with these tests:

  1. LiteDB has some rounding behaviour for datetime's which if you are using LiteDB for a wallet you should be aware of. This was causing tests to fail.
  2. There was a couple of tests that used test data that made assumption of date/time locality. I corrected those to be explicit.

Copy link
Copy Markdown
Member

@dangershony dangershony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But wallet unit tests are not failing are they?

Copy link
Copy Markdown
Member

@dangershony dangershony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this will fix the linux failures

@dangershony dangershony merged commit 56509ff into block-core:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RemoveTransaction wallet tests fail in Blockcore.Features.Wallet.Tests

2 participants