Merged
Conversation
sondreb
requested changes
Oct 21, 2020
Member
sondreb
left a comment
sondreb
left a comment
There was a problem hiding this comment.
Good work, appears there might be one issue that might cause a crash due to casting? Also seperate leveldb and rocksdb in some places.
sondreb
requested changes
Oct 22, 2020
Member
sondreb
left a comment
sondreb
left a comment
There was a problem hiding this comment.
Can the code throw exception if a dbtype is specified that is not yet supported? I couldn't find the enum code if it contains only the 2 supported or 4?
sondreb
approved these changes
Oct 23, 2020
sondreb
approved these changes
Oct 23, 2020
Contributor
|
I'll take some time later to do a proper review on code |
Contributor
|
here my implementation #235 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add a new DbType that can be set in the command line parameters.
-dbtype=[rocksdb,leveldb]default is leveldb