Make sure that each query against database uses a new connection object#300
Merged
Make sure that each query against database uses a new connection object#300
Conversation
Member
dangershony
commented
Mar 9, 2021
dangershony
commented
- This is the smallest impact and quickest way to fix the issue with connections against sqlite database.
- Closes Sqlite wallet issue #299
- This is the smallest impact and quickest way to fix the issue with connections against sqlite database. - Closes #299
Member
Author
|
We probably need to run all tests locally on this one, I will do it now. |
dangershony
commented
Mar 9, 2021
Contributor
|
at a first glance I see you didn't disposed any connection. |
MithrilMan
reviewed
Mar 9, 2021
Contributor
MithrilMan
left a comment
MithrilMan
left a comment
There was a problem hiding this comment.
seems good to me, just added some comments
dangershony
commented
Mar 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.