Cache the deployment flags to improve startup#340
Merged
Conversation
Member
sondreb
commented
May 18, 2021
sondreb
commented
- The deployment flags are cached when calculated as new blocks come in.
- The deployment flags are read from cache at startup, as they cannot have changed since shutdown.
- This gives a very big improvement on node startup.
- Node startup performance #337
- The deployment flags are cached when calculated as new blocks come in. - The deployment flags are read from cache at startup, as they cannot have changed since shutdown. - This gives a very big improvement on node startup. - #337
- Needed for tests.
dangershony
reviewed
May 18, 2021
dangershony
requested changes
May 18, 2021
Member
dangershony
left a comment
dangershony
left a comment
There was a problem hiding this comment.
This is a good idea but we should move the persist to the base feature
Member
I think its already cached in the component |
- Check the flags every minute and persist if needed. - This only validates ScriptFlags, not BIP30/BIP34/LockTimeFlags.
Member
Author
Yes, it loads pre-calculated on startup, from the key-value store. We never need to re-calculate from genesis on secondary launches of the software. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.