Add OpReturnDataIsHex in build-tx-request to store hex bytes#348
Merged
sondreb merged 8 commits intoblock-core:masterfrom Aug 17, 2021
Merged
Add OpReturnDataIsHex in build-tx-request to store hex bytes#348sondreb merged 8 commits intoblock-core:masterfrom
sondreb merged 8 commits intoblock-core:masterfrom
Conversation
dangershony
reviewed
Aug 4, 2021
dangershony
reviewed
Aug 4, 2021
Member
|
|
Member
|
We cannot modify the existing history API with slim method, this is a breaking change and changes what is returned. The PR also broke many tests which relies on the current API. I have instead introduced history/slim which will return the slim version of history. Important to note that slim will discard transactions that are sent to the self wallet. |
sondreb
approved these changes
Aug 17, 2021
Member
sondreb
left a comment
sondreb
left a comment
There was a problem hiding this comment.
This can now be approved. The slim is moved into separate API, and the fee-calculation also supports hex parsing of opreturn data.
sondreb
added a commit
to turcol/blockcore
that referenced
this pull request
Aug 17, 2021
sondreb
added a commit
to turcol/blockcore
that referenced
this pull request
Aug 17, 2021
sondreb
added a commit
that referenced
this pull request
Aug 17, 2021
* Add OpReturnDataIsHex in build-tx-request to store hex bytes * Update checkpoints * Update checkpoints Rutanio * Add missing comma at the EOL * Remove modifications that has been added in separate PR #348 * Minor syntax change * Remove OpenExo checkpoints that has been approved in #348 Co-authored-by: Sondre <sondre@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.