Skip to content

Adding support for Strax#355

Merged
dangershony merged 4 commits intomasterfrom
strax
Oct 5, 2021
Merged

Adding support for Strax#355
dangershony merged 4 commits intomasterfrom
strax

Conversation

@dangershony
Copy link
Copy Markdown
Member

Replaces the initial PR by @zeptin
#278

@dangershony
Copy link
Copy Markdown
Member Author

Note
federation overrides OP_NOP9 to push fed pub keys to the stack and the
needed signatures to satisfy the federation multisig, to avoid changing
the script engine for now we ignore such outputs and consider them valid
(as was with the opcode OP_NOP9) a malicious node may cause blockcore nodes
to accept invalid blocks however as long as blockcore nodes are minority nodes
its an acceptable risk, users not part of a federation should not really be effected.

@zeptin thoughts?

@dangershony
Copy link
Copy Markdown
Member Author

All test pass locally

@dangershony dangershony merged commit c298c3e into master Oct 5, 2021
@dangershony dangershony deleted the strax branch October 5, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants