Add the ability to not auto-create hot account when activate cold sta…#360
Merged
Add the ability to not auto-create hot account when activate cold sta…#360
Conversation
…king
- Need review and discussion if an additional API endpoint should be added ("setup-offline-staking") or if simply the "SetupColdStakingRequest" type should be expanded with an extra property?
dangershony
reviewed
Oct 18, 2021
| HdAccount hotAccount = this.GetOrCreateColdStakingAccount(walletName, false, walletPassword); | ||
| HdAccount hotAccount; | ||
|
|
||
| if (createHotAccount) |
Member
There was a problem hiding this comment.
Wait the problem is only with hot accounts?
Member
Author
There was a problem hiding this comment.
The problem is having both active at the same time, there is no need for the reversed.
Member
|
Why are tests failing? is it to do with this change? |
dangershony
approved these changes
Oct 18, 2021
Member
dangershony
left a comment
dangershony
left a comment
There was a problem hiding this comment.
looks good just need to check tests
Member
|
Why all tests failed? I will rerun them |
Member
|
This is now good to push |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…king