Add endpoint to return the network weight for POS chains#377
Merged
dangershony merged 4 commits intomasterfrom Jan 21, 2022
Merged
Add endpoint to return the network weight for POS chains#377dangershony merged 4 commits intomasterfrom
dangershony merged 4 commits intomasterfrom
Conversation
sondreb
requested changes
Jan 20, 2022
Member
sondreb
left a comment
sondreb
left a comment
There was a problem hiding this comment.
Good work! At minimum the error message must be fixed.
Member
Author
|
I will wait for tests then push |
Member
Author
|
All tests passed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Endpoints to get the POS network difficulty to be used with the indexer for this issue
block-core/blockcore-indexer#56
There are two approaches this can go:
GetBlock(then on the explorer we can display the network weight on each block)(note the difficulty on POS is calculated slightly differently when it comes to calculating the network weight)