Skip to content

Add XDS network#83

Merged
dangershony merged 6 commits intoblock-core:masterfrom
dangershony:xds-network
Apr 15, 2020
Merged

Add XDS network#83
dangershony merged 6 commits intoblock-core:masterfrom
dangershony:xds-network

Conversation

@dangershony
Copy link
Copy Markdown
Member

@dangershony dangershony commented Mar 14, 2020

This is still WIP

Based on https://github.com/sonofsatoshi2020/xds

@dangershony dangershony changed the title Add Xds network Add XDS network Mar 14, 2020
@thecrypt0hunter
Copy link
Copy Markdown
Contributor

Some feedback:

  1. The data directory has moved from .fullnoderoot/xds/MainNet to .Blockcore/xds/XdsMain. This means people will likely end up needing to re-sync
  2. I couldn't copy my wallet across to Blockcore, I guess I'll have to recover from seed words.

@sondreb
Copy link
Copy Markdown
Member

sondreb commented Mar 15, 2020

I believe that wallet copy should be responsibility of the UI, not the FN.

@thecrypt0hunter
Copy link
Copy Markdown
Contributor

What I mean is that the Blockcore XDS daemon won't load when I manually copied my old XDS wallet file over to the Blockcore data directory. So I am going to try to restore from seed words using the new daemon.

@dangershony
Copy link
Copy Markdown
Member Author

@thecrypt0hunter yes resync is needed anyway because of a bug fix.

Its odd wallet doesn't work, I cant try it myself as well.

@thecrypt0hunter
Copy link
Copy Markdown
Contributor

thecrypt0hunter commented Mar 16, 2020

This codebase also has the "dust" error.

Detailed here: sonofsatoshi2020/xds#8

@dangershony
Copy link
Copy Markdown
Member Author

All tests passed on this

@thecrypt0hunter
Copy link
Copy Markdown
Contributor

Using this API in swagger:

/api/Staking/getStakingNotExpired

I receive this error:

TypeError: Failed to execute 'fetch' on 'Window': Request with GET/HEAD method cannot have body.

It works fine if I call using CURL command

@dangershony dangershony merged commit 2273fd4 into block-core:master Apr 15, 2020
@dangershony dangershony deleted the xds-network branch April 15, 2020 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants