Move properties to the root .props file#94
Merged
sondreb merged 1 commit intoblock-core:masterfrom Apr 18, 2020
sondreb:feature/improve-usage-of-props
Merged
Move properties to the root .props file#94sondreb merged 1 commit intoblock-core:masterfrom sondreb:feature/improve-usage-of-props
sondreb merged 1 commit intoblock-core:masterfrom
sondreb:feature/improve-usage-of-props
Conversation
Member
sondreb
commented
Apr 18, 2020
sondreb
commented
- This commit moves most of the properties from individual project files into a shared props file.
- The props files are not inherited, so they are all removed from individual folders which was used to set the IsPackable property. This is added to individual project files instead.
- Delete all AssemblyInfo.cs files from properties folder.
- Move all version properties into a singular place, making updates easier.
- Changes the assembly name of NBitcoin fork to "Blockcore.NBitcoin".
- Automatically makes internals visible to .Tests projects based on script in .props file.
- Remove some old NETCORE conditional checks.
- This commit moves most of the properties from individual project files into a shared props file. - The props files are not inherited, so they are all removed from individual folders which was used to set the IsPackable property. This is added to individual project files instead. - Delete all AssemblyInfo.cs files from properties folder. - Move all version properties into a singular place, making updates easier. - Changes the assembly name of NBitcoin fork to "Blockcore.NBitcoin". - Automatically makes internals visible to .Tests projects based on script in .props file. - Remove some old NETCORE conditional checks.
dangershony
approved these changes
Apr 18, 2020
Member
dangershony
left a comment
dangershony
left a comment
There was a problem hiding this comment.
I did not run tests or sync networks but I think this is fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.