Skip to content

feat(memory): require review for memory proposals - #289

Draft
delkc wants to merge 1 commit into
clay/memory-foundationfrom
clay/memory-review
Draft

feat(memory): require review for memory proposals#289
delkc wants to merge 1 commit into
clay/memory-foundationfrom
clay/memory-review

Conversation

@delkc

@delkc delkc commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Require an explicit review decision before an agent suggestion becomes durable or recallable memory.

  • Keep agent suggestions in a local pending queue until the person approves them
  • Provide editable approval and decline controls in Settings → Memory
  • Show Review and Decline notifications, including session-safe handling for MCP proposals
  • Use salted, content-free suppression fingerprints for declines and unambiguous manual deletions
  • Serialize and idempotently apply approval in Rust, with credential validation and scoped destination routing

Related issue

N/A. Depends on #288.

Testing

  • Proposal parsing, review, suppression, and notification tests
  • Backend approval retry, credential rejection, and queue tests
  • TypeScript typecheck, i18n, Biome, and design-system checks

Generated with Goose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant