Harden delta sink counter tracking#167
Merged
Merged
Conversation
Preserve metric batch metadata, disambiguate counter series, and protect counter state during concurrent sends without changing Retry queueing behavior. Co-authored-by: Codex <noreply@openai.com> Ai-assisted: true
Areson
marked this pull request as ready for review
July 15, 2026 20:23
JashLal
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The delta sink could lose batch metadata, collide unrelated cumulative counter series, and race when multiple goroutines transformed metrics concurrently.
What
Risk Assessment
Low — the change is isolated to cumulative-counter transformation and preserves the existing Retry integration behavior. Counter reset behavior remains unchanged and is now explicitly tested.
References
env -u GOROOT go test ./sink -count=1 -timeout=4menv -u GOROOT go test -race ./sink -count=1 -timeout=4mGenerated with Codex