Skip to content

fix(penpal): match file view right margin to left margin - #522

Merged
loganj merged 2 commits into
mainfrom
loganj/penpal-11-file-view-right-margin-should-be-same-as-left-margin
Mar 29, 2026
Merged

fix(penpal): match file view right margin to left margin#522
loganj merged 2 commits into
mainfrom
loganj/penpal-11-file-view-right-margin-should-be-same-as-left-margin

Conversation

@loganj

@loganj loganj commented Mar 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Removes max-width: 900px from .file-main-scroll so content expands to fill available space
  • Symmetric 40px padding on both sides ensures equal margins between content and sidebar/comments panel
  • Adds vitest test verifying symmetric padding and absence of max-width constraint
  • Updates ANCHORS docs (PRODUCT.md, ERD.md, TESTING.md) with P-PENPAL-VIEW-MARGINS / E-PENPAL-VIEW-MARGINS

Closes https://linear.app/squareup/issue/PENPAL-11

🤖 Generated with Claude Code

@loganj
loganj force-pushed the loganj/penpal-11-file-view-right-margin-should-be-same-as-left-margin branch 2 times, most recently from e9dcbf9 to f70536a Compare March 29, 2026 02:56
@loganj
loganj marked this pull request as ready for review March 29, 2026 02:57

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f70536aa2f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/penpal/frontend/src/test/file-view-layout.test.ts Outdated
@loganj
loganj force-pushed the loganj/penpal-11-file-view-right-margin-should-be-same-as-left-margin branch from 9ddcfba to 63e7f41 Compare March 29, 2026 03:30
Removes the max-width: 900px constraint on .file-main-scroll so content
expands to fill available space with symmetric 40px padding on both sides,
ensuring consistent margins between content and both sidebar boundaries.

Closes PENPAL-11

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@loganj
loganj force-pushed the loganj/penpal-11-file-view-right-margin-should-be-same-as-left-margin branch from 63e7f41 to a62c0d3 Compare March 29, 2026 03:34
The file-view-layout test used CJS-style Node.js imports (fs, path,
__dirname) without @types/node, causing tsc --noEmit to fail in CI.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@loganj
loganj merged commit 9c13276 into main Mar 29, 2026
6 checks passed
@loganj
loganj deleted the loganj/penpal-11-file-view-right-margin-should-be-same-as-left-margin branch March 29, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant