Skip to content

feat(staged): add full-screen diagram viewer#851

Merged
matt2e merged 8 commits into
mainfrom
diagram-max-size
Jul 3, 2026
Merged

feat(staged): add full-screen diagram viewer#851
matt2e merged 8 commits into
mainfrom
diagram-max-size

Conversation

@matt2e

@matt2e matt2e commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • Add a full-screen modal viewer for rendered markdown diagrams in notes and sessions.
  • Implement D3-powered diagram pan/zoom, fit-to-bounds behavior, fullscreen navigation, and repeated double-click zoom.
  • Refresh diagram styles/theme tokens and add diagram zoom coverage.

Tests:

  • Pre-push hooks ran on push: crates-fmt, crates-test, crates-lint, differ-ci, staged-ci.

@matt2e
matt2e requested review from baxen and wesbillman as code owners July 3, 2026 03:54

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 32d865ac1d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

height: 100%;
max-width: none;
max-height: none;
overflow: hidden;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve Pikchr overflow in the full-screen viewer

When a Pikchr SVG relies on drawing outside its viewBox, the inline preview keeps that content visible via the existing .markdown-diagram-preview-pikchr .markdown-pikchr-svg { overflow: visible } rule, but the full-screen copy is rendered under .diagram-surface and this line forces the root SVG back to overflow: hidden. Opening those diagrams in the new viewer clips labels/strokes that are visible in the preview, so the modal should explicitly keep Pikchr SVG overflow visible or reuse the preview rule.

Useful? React with 👍 / 👎.

@matt2e
matt2e force-pushed the diagram-max-size branch from 32d865a to 473c06f Compare July 3, 2026 04:42
matt2e added 8 commits July 3, 2026 14:47
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
@matt2e
matt2e force-pushed the diagram-max-size branch from 473c06f to ff5b970 Compare July 3, 2026 04:52
@matt2e
matt2e merged commit 576961b into main Jul 3, 2026
6 checks passed
@matt2e
matt2e deleted the diagram-max-size branch July 3, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant