Skip to content

fix: remove project sidebar toggle #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt2e merged 1 commit into from
Jul 6, 2026
Merged

fix: remove project sidebar toggle #860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 1 addition & 41 deletions apps/staged/src/lib/features/projects/ProjectHome.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
import AlertCircle from '@lucide/svelte/icons/alert-circle';
import CirclePause from '@lucide/svelte/icons/circle-pause';
import Cloud from '@lucide/svelte/icons/cloud';
import PanelLeftClose from '@lucide/svelte/icons/panel-left-close';
import PanelLeftOpen from '@lucide/svelte/icons/panel-left-open';
import Pause from '@lucide/svelte/icons/pause';
import Plus from '@lucide/svelte/icons/plus';
import Trash2 from '@lucide/svelte/icons/trash-2';
Expand Down Expand Up @@ -39,12 +37,7 @@
import * as AlertDialog from '$lib/components/ui/alert-dialog';
import { Button } from '$lib/components/ui/button';
import { toast } from 'svelte-sonner';
import {
projectsSidebarState,
setProjects,
setProjectsSidebarCollapsed,
} from './projectsSidebarState.svelte';
import { viewport } from '../../shared/viewport.svelte';
import { setProjects } from './projectsSidebarState.svelte';
import { workspaceLifecycle } from './workspaceLifecycle.svelte';
import { projectRunActionsStore } from '../../stores/projectRunActions.svelte';
import { repoBadgeStore } from '../../stores/repoBadges.svelte';
Expand Down Expand Up @@ -724,8 +717,6 @@
)
: new Set<string>()
);
let sidebarOpen = $derived(!projectsSidebarState.collapsed);

let reposByProject = $derived(
new Map(
projects.map((project) => {
Expand Down Expand Up @@ -1075,10 +1066,6 @@
}
}

function toggleProjectsSidebar() {
setProjectsSidebarCollapsed(!projectsSidebarState.collapsed);
}

async function handleTopBarRepoSelected(selection: RepoPickerSelection) {
const project = selectedProject;
if (!project) return;
Expand Down Expand Up @@ -1162,38 +1149,11 @@

<TopBarPortal
title={selectedProject ? '' : 'Project'}
leftActions={projectTopBarLeftActions}
center={projectTopBarCenter}
badges={projectTopBarBadges}
rightActions={projectTopBarRightActions}
/>

{#snippet projectTopBarLeftActions()}
{#if !viewport.isMobile}
<span
class="inline-flex"
title={sidebarOpen ? 'Hide projects sidebar' : 'Show projects sidebar'}
>
<Button
variant="ghost"
size="sm"
class="top-bar-action gap-1.5 text-foreground hover:bg-[var(--ui-selection)] hover:text-foreground max-md:size-10 max-md:p-0 [&_svg]:size-3.5"
aria-label={sidebarOpen ? 'Hide projects sidebar' : 'Show projects sidebar'}
onclick={toggleProjectsSidebar}
disabled={!projectsSidebarState.hasProjects}
>
{#if !sidebarOpen || !projectsSidebarState.hasProjects}
<PanelLeftOpen size={14} />
<span class="top-bar-action-label">Show Sidebar</span>
{:else}
<PanelLeftClose size={14} />
<span class="top-bar-action-label">Hide Sidebar</span>
{/if}
</Button>
</span>
{/if}
{/snippet}

{#snippet projectTopBarCenter()}
{#if selectedProject && showTopBarProjectName}
{@const topBarProjectName = projectDisplayName(selectedProject)}
Expand Down
4 changes: 1 addition & 3 deletions apps/staged/src/lib/features/projects/ProjectsSidebar.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,9 +300,7 @@
let resizing = $state(false);
let resizeStartX = 0;
let resizeStartWidth = SIDEBAR_DEFAULT_WIDTH;
let sidebarVisible = $derived(
projectsSidebarState.hasProjects && !viewport.isMobile && !projectsSidebarState.collapsed
);
let sidebarVisible = $derived(projectsSidebarState.hasProjects && !viewport.isMobile);
let sidebarStyle = $derived(`width: ${projectsSidebarState.width}px;`);

onMount(() => {
Expand Down
16 changes: 1 addition & 15 deletions apps/staged/src/lib/features/projects/projectsSidebarState.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import type { Project } from '../../types';
import { getStoreValue, setStoreValue } from '../../shared/persistentStore';

const SIDEBAR_WIDTH_KEY = 'projects-sidebar-width';
const SIDEBAR_COLLAPSED_KEY = 'projects-sidebar-collapsed';

export const SIDEBAR_DEFAULT_WIDTH = 280;
export const SIDEBAR_MIN_WIDTH = 220;
Expand All @@ -22,7 +21,6 @@ export const projectsList = $state<{ current: Project[] }>({ current: [] });

export const projectsSidebarState = $state({
width: SIDEBAR_DEFAULT_WIDTH,
collapsed: false,
hydrated: false,
hasProjects: true,
scrollTop: 0,
Expand All @@ -31,17 +29,11 @@ export const projectsSidebarState = $state({
export async function hydrateProjectsSidebarState(): Promise<void> {
if (projectsSidebarState.hydrated) return;

const [savedWidth, savedCollapsed] = await Promise.all([
getStoreValue<number>(SIDEBAR_WIDTH_KEY),
getStoreValue<boolean>(SIDEBAR_COLLAPSED_KEY),
]);
const savedWidth = await getStoreValue<number>(SIDEBAR_WIDTH_KEY);

if (typeof savedWidth === 'number' && Number.isFinite(savedWidth)) {
projectsSidebarState.width = clampWidth(savedWidth);
}
if (typeof savedCollapsed === 'boolean') {
projectsSidebarState.collapsed = savedCollapsed;
}

projectsSidebarState.hydrated = true;
}
Expand All @@ -65,9 +57,3 @@ export function setProjectsSidebarScrollTop(scrollTop: number): void {
if (!Number.isFinite(scrollTop)) return;
projectsSidebarState.scrollTop = Math.max(0, scrollTop);
}

export function setProjectsSidebarCollapsed(collapsed: boolean): void {
if (projectsSidebarState.collapsed === collapsed) return;
projectsSidebarState.collapsed = collapsed;
void setStoreValue(SIDEBAR_COLLAPSED_KEY, collapsed);
}