feat: add split note chat pane#866
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e618c719cd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| {@const split = splitAtNoteIndicator(group.message.content, { | ||
| streaming: isLive && groupIdx === grouped.length - 1, | ||
| })} |
There was a problem hiding this comment.
Scope note truncation to note sessions
When this pane is used for plain chat/commit sessions (for example, the DiffModal SessionModal path has no linked note context), every assistant message is still passed through splitAtNoteIndicator. Any normal Markdown response containing a horizontal rule such as Intro\n---\nDetails will render only the preamble and a “Note created/updated” card, hiding the rest of the answer even though backend note extraction only runs when a note target exists. Gate this splitting on a note-writing/linked-note context instead of applying it to all assistant messages.
Useful? React with 👍 / 👎.
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Rename the first note activity label to "Note created", render note activity cards as passive outlined statuses, and continue the split divider through the note modal header with the copy action on the note side. Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Summary