Conversation
The check read and set `core.clonefile`, a git config key that git does not recognize (git silently ignores unknown `core.*` keys), and staged's worktree creation runs plain `git worktree add`, which writes files fresh from the object store — there is no file-copy step a copy-on-write filesystem could accelerate. The check therefore nagged every user with a permanent Warn until they wrote an inert key into their global gitconfig. Delete `check_clonefile()`, the `CLONEFILE_FIX_COMMAND` constant, the `git-clonefile` special case in `lookup_fix_command()`, and the check's spawn/join wiring in `run_checks`. The staged app needed no changes: the settings panel renders checks generically, and the only remaining `clonefile(2)` use is the unrelated image copy in session_commands.rs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
git-clonefiledoctor check, which nagged every user with a permanent Warn for no benefit.Why
core.clonefile, which git does not recognize — git silently ignores unknowncore.*keys, so setting it does nothing.git worktree add, which writes files fresh from the object store. There is no file-copy step a copy-on-write filesystem could accelerate.Changes
check_clonefile()and theCLONEFILE_FIX_COMMANDconstant (crates/doctor/src/checks.rs).git-clonefilespecial case fromlookup_fix_command()(crates/doctor/src/agents.rs).collect_base_report()(crates/doctor/src/lib.rs).No app-side changes needed: the settings panel renders checks generically, and the only remaining
clonefile(2)use is the unrelated image copy insession_commands.rs.🤖 Generated with Claude Code