feat(agents): add tier-1 buzz-agent model-tuning fields to Create/Edit dialogs#1534
Merged
wpfleger96 merged 2 commits intoJul 6, 2026
Merged
Conversation
…t dialogs Adds four dedicated, editable fields to the managed-agent Create and Edit dialogs so users can configure buzz-agent model-tuning knobs without hand-typing raw env var keys: - Thinking / Effort (select: none|minimal|low|medium|high|xhigh|max) - Max rounds (numeric) - Max output tokens (numeric) - Context limit (numeric) Each field writes its value as a BUZZ_AGENT_* key into the existing envVars map — no new persistence path or record-schema change. Empty field = inherit: the key is absent from envVars and the placeholder shows the global/persona baseline from inheritedEnvVars. Non-empty = explicit override. Fields are gated on isBuzzAgentRuntime(selectedRuntimeId) and rendered via a private BuzzAgentModelTuningFields component — non-buzz-agent runtimes see nothing. A source-of-truth constant BUZZ_AGENT_THINKING_EFFORT_VALUES mirrors parse_thinking_effort in crates/buzz-agent/src/config.rs. 14 behavior-focused unit tests cover: empty→inherit, set→writes key, clear→deletes key, correct key names, bounded select values, multi- field isolation. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
The Edit dialog collapses selectedRuntimeId to an 'inherit'/'custom' sentinel that drives the custom-command input visibility. The tier-1 model-tuning gate was using this same prop, so isBuzzAgentRuntime always saw 'inherit' in Edit and the fields were never rendered. Fixes: - Add modelTuningRuntimeId prop to CreateAgentRuntimeFields, separate from the existing selectedRuntimeId sentinel. Gate the tier-1 fields on isBuzzAgentRuntime(modelTuningRuntimeId). - Edit passes prospectiveRuntimeId (already resolves inherit→persona command, covers both inherited and pinned buzz-agent personas). - Create passes selectedRuntimeId (no sentinel needed; the real id is always available there). - Fix min="0" on Max Rounds (backend default is 0 = unlimited; explicit 0 is a valid override to lift a finite cap set via persona/global). Add '0 = unlimited' to the help text. - Add 4 regression tests covering the Edit runtime-id mapping: sentinel 'inherit' must not trigger fields; prospectiveRuntimeId 'buzz-agent' must; goose/empty must not. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
wesbillman
approved these changes
Jul 6, 2026
Collaborator
Author
wpfleger96
pushed a commit
that referenced
this pull request
Jul 6, 2026
wpfleger96
added a commit
that referenced
this pull request
Jul 6, 2026
…t dialogs (#1534) Signed-off-by: Will Pfleger <pfleger.will@gmail.com> Co-authored-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@sprout-oss.stage.blox.sqprod.co>
wpfleger96
added a commit
that referenced
this pull request
Jul 6, 2026
…mmands #1534 (buzz-agent model-tuning) added Tauri commands for reading and writing the model-tuning fields, growing agents.rs by 6 lines beyond the 1449 exception. Bump to 1455 to cover the merged total. Queued to split. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
wpfleger96
added a commit
that referenced
this pull request
Jul 6, 2026
…t dialogs (#1534) Signed-off-by: Will Pfleger <pfleger.will@gmail.com> Co-authored-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@sprout-oss.stage.blox.sqprod.co>
wpfleger96
added a commit
that referenced
this pull request
Jul 6, 2026
…mmands #1534 (buzz-agent model-tuning) added Tauri commands for reading and writing the model-tuning fields, growing agents.rs by 6 lines beyond the 1449 exception. Bump to 1455 to cover the merged total. Queued to split. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
wpfleger96
added a commit
that referenced
this pull request
Jul 6, 2026
…t dialogs (#1534) Signed-off-by: Will Pfleger <pfleger.will@gmail.com> Co-authored-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@sprout-oss.stage.blox.sqprod.co>
wpfleger96
added a commit
that referenced
this pull request
Jul 6, 2026
…mmands #1534 (buzz-agent model-tuning) added Tauri commands for reading and writing the model-tuning fields, growing agents.rs by 6 lines beyond the 1449 exception. Bump to 1455 to cover the merged total. Queued to split. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
wpfleger96
added a commit
that referenced
this pull request
Jul 6, 2026
…t dialogs (#1534) Signed-off-by: Will Pfleger <pfleger.will@gmail.com> Co-authored-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@sprout-oss.stage.blox.sqprod.co>
wpfleger96
added a commit
that referenced
this pull request
Jul 6, 2026
…mmands #1534 (buzz-agent model-tuning) added Tauri commands for reading and writing the model-tuning fields, growing agents.rs by 6 lines beyond the 1449 exception. Bump to 1455 to cover the merged total. Queued to split. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
wpfleger96
added a commit
that referenced
this pull request
Jul 6, 2026
…t dialogs (#1534) Signed-off-by: Will Pfleger <pfleger.will@gmail.com> Co-authored-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@sprout-oss.stage.blox.sqprod.co>
wpfleger96
added a commit
that referenced
this pull request
Jul 6, 2026
…mmands #1534 (buzz-agent model-tuning) added Tauri commands for reading and writing the model-tuning fields, growing agents.rs by 6 lines beyond the 1449 exception. Bump to 1455 to cover the merged total. Queued to split. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
wpfleger96
added a commit
that referenced
this pull request
Jul 7, 2026
…t dialogs (#1534) Signed-off-by: Will Pfleger <pfleger.will@gmail.com> Co-authored-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@sprout-oss.stage.blox.sqprod.co>
wpfleger96
added a commit
that referenced
this pull request
Jul 7, 2026
…mmands #1534 (buzz-agent model-tuning) added Tauri commands for reading and writing the model-tuning fields, growing agents.rs by 6 lines beyond the 1449 exception. Bump to 1455 to cover the merged total. Queued to split. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
wpfleger96
added a commit
that referenced
this pull request
Jul 7, 2026
…t dialogs (#1534) Signed-off-by: Will Pfleger <pfleger.will@gmail.com> Co-authored-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@sprout-oss.stage.blox.sqprod.co>
wpfleger96
added a commit
that referenced
this pull request
Jul 8, 2026
…t dialogs (#1534) Signed-off-by: Will Pfleger <pfleger.will@gmail.com> Co-authored-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@sprout-oss.stage.blox.sqprod.co>
wpfleger96
added a commit
that referenced
this pull request
Jul 8, 2026
…t dialogs (#1534) Signed-off-by: Will Pfleger <pfleger.will@gmail.com> Co-authored-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@sprout-oss.stage.blox.sqprod.co>
wpfleger96
added a commit
that referenced
this pull request
Jul 8, 2026
…t dialogs (#1534) Signed-off-by: Will Pfleger <pfleger.will@gmail.com> Co-authored-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@sprout-oss.stage.blox.sqprod.co>
wpfleger96
added a commit
that referenced
this pull request
Jul 8, 2026
…t dialogs (#1534) Signed-off-by: Will Pfleger <pfleger.will@gmail.com> Co-authored-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@sprout-oss.stage.blox.sqprod.co>
wpfleger96
added a commit
that referenced
this pull request
Jul 8, 2026
…t dialogs (#1534) Signed-off-by: Will Pfleger <pfleger.will@gmail.com> Co-authored-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@sprout-oss.stage.blox.sqprod.co>
wpfleger96
added a commit
that referenced
this pull request
Jul 8, 2026
…t dialogs (#1534) Signed-off-by: Will Pfleger <pfleger.will@gmail.com> Co-authored-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@sprout-oss.stage.blox.sqprod.co>
wpfleger96
added a commit
that referenced
this pull request
Jul 8, 2026
…t dialogs (#1534) Signed-off-by: Will Pfleger <pfleger.will@gmail.com> Co-authored-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@sprout-oss.stage.blox.sqprod.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Closes the #1470 UI gap: adds four dedicated editable fields to the managed-agent Create and Edit dialogs so users can configure buzz-agent model-tuning knobs without hand-typing raw env var keys.
What this adds
Four fields rendered inside
CreateAgentRuntimeFields(shared by both dialogs), gated onisBuzzAgentRuntime(modelTuningRuntimeId)— non-buzz-agent runtimes see nothing:BUZZ_AGENT_THINKING_EFFORT<select>— 7 values + InheritBUZZ_AGENT_MAX_ROUNDSBUZZ_AGENT_MAX_OUTPUT_TOKENSBUZZ_AGENT_MAX_CONTEXT_TOKENSInherit pattern (matches #1448)
Empty field = inherit: key is absent from
envVars; placeholder shows the inherited baseline frominheritedEnvVars(global + persona chain). Non-empty = explicit override written intoenvVars. No payload shape change — values already ride in theenvVarsmap.CreateAgentDialogpassesglobalConfig.env_varsas the baseline (global-only; no persona on create)EditAgentDialogpassesinheritedWithGlobal(global + linked persona, matching the existing EnvVarsEditor wiring)Prop split: modelTuningRuntimeId vs selectedRuntimeId
The Edit dialog collapses
selectedRuntimeIdto an"inherit"/"custom"sentinel that drives the custom-command input. A separatemodelTuningRuntimeIdprop carries the real/prospective runtime id for the model-tuning gate:prospectiveRuntimeId(resolves inherit → persona command; covers both inherited and pinned buzz-agent)selectedRuntimeIddirectly (no sentinel needed; the real id is always available)Files
buzzAgentConfig.ts— source-of-truth constants: env var key names,BUZZ_AGENT_THINKING_EFFORT_VALUES(mirrorsparse_thinking_effortincrates/buzz-agent/src/config.rs),isBuzzAgentRuntimebuzzAgentConfig.test.mjs— 18 behavior-focused unit tests (14 original + 4 regression tests for the Edit runtime-id mapping)CreateAgentDialogSections.tsx— 4 new fields +modelTuningRuntimeIdprop split; privateBuzzAgentModelTuningFieldscomponentCreateAgentDialog.tsx/EditAgentDialog.tsx— wire the new propsStack: #1411 → #1448 → this PR
Related: #1411, #1448, #1470