chore(desktop): remove container-only npm-preflight E2E harness#1749
Merged
Conversation
The four #[ignore]d container tests and their Docker harness (Dockerfile.preflight-e2e, Dockerfile.preflight-e2e.dockerignore, run-e2e-scenarios.sh, desktop-preflight-e2e Justfile recipe) were opt-in scaffolding added for pre-merge confidence on #1732. They were never wired into CI and never ran in just check or desktop-test. Will's call: dead weight for the tree. Removing it now that the fix has landed. Production code is untouched: NpmPrefix enum, resolve_npm_prefix(), npm_preflight_check(), npm_install_target_is_writable(), the hint field, all non-ignored unit tests, and the frontend diff all remain. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
cargo fmt left a stray blank line before the closing brace of mod tests after the E2E test tail was removed. Run cargo fmt to fix. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
tlongwell-block
pushed a commit
that referenced
this pull request
Jul 11, 2026
Co-authored-by: Tyler Longwell <tlongwell@block.xyz> Signed-off-by: Tyler Longwell <tlongwell@block.xyz> * origin/main: fix(desktop): preserve archived observer history (#1752) fix(dev): install Lefthook hooks into shared .git/hooks dir (#1751) fix(desktop): surface codex config-parse failures and -32603 internal errors clearly (#1745) fix(desktop): fix workspace rail badge disappearance and persist mark-as-unread (#1747) chore(desktop): remove container-only npm-preflight E2E harness (#1749) fix(desktop): preflight npm prefix writability in doctor installs (#1732)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four
#[ignore]d container tests and their Docker harness (Dockerfile.preflight-e2e,Dockerfile.preflight-e2e.dockerignore,run-e2e-scenarios.sh,desktop-preflight-e2eJustfile recipe) were opt-in scaffolding added for pre-merge confidence on #1732. They were never wired into CI and never ran injust checkordesktop-test.Will's call: dead weight for the tree. Removing it now that the fix has landed.
Production code is untouched:
NpmPrefixenum,resolve_npm_prefix(),npm_preflight_check(),npm_install_target_is_writable(), thehintfield, all non-ignored unit tests, and the frontend diff all remain.