Skip to content

feat(desktop): redesign Nostr bind verification flow#1850

Open
klopez4212 wants to merge 1 commit into
mainfrom
kennylopez-onboarding-bind-screen
Open

feat(desktop): redesign Nostr bind verification flow#1850
klopez4212 wants to merge 1 commit into
mainfrom
kennylopez-onboarding-bind-screen

Conversation

@klopez4212

@klopez4212 klopez4212 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • restyle the Nostr identity-binding prompt as a full-page onboarding flow
  • require the six-digit browser code before signing, with accessible OTP input, mismatch feedback, and reduced-motion-safe transitions
  • add a finish step that exposes the signed response with an explicit copy action
  • include a DEV-only seeded preview for safely reviewing the flow in the native staging app

Testing

  • just ci
  • Code Reviewer: no blocking findings
  • focused Playwright coverage for OTP entry/paste/navigation, mismatch and repeated shake behavior, sixth-slot input lock, reduced motion, step transition, signed response, and clipboard copy

Screenshots

Enter verification code

Six portrait code slots with Continue gated until the browser code matches.

01-enter-code

Code mismatch

Persistent, layout-stable mismatch feedback using the specified error treatment and shake motion.

02-code-mismatch

Finish verification

The signed response is shown in a readable code container with an explicit copy action.

03-finish-verification

@klopez4212 klopez4212 requested a review from a team as a code owner July 14, 2026 09:05
klopez4212 added a commit that referenced this pull request Jul 14, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bf1f5a2c4d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/profile/ui/NostrBindConsentDialog.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant