Skip to content

Refine channel lifecycle settings #2427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klopez4212 merged 5 commits into from
Jul 23, 2026
Merged

Refine channel lifecycle settings #2427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
975dd4e
Refine channel lifecycle settings
klopez4212 Jul 22, 2026
52a1477
Merge remote-tracking branch 'origin/main' into kennylopez-edit-chann…
klopez4212 Jul 22, 2026
409efaf
Rename channel permissions to visibility
klopez4212 Jul 23, 2026
8499e43
Reset cancelled channel edit drafts
klopez4212 Jul 23, 2026
c24fa5d
Guard channel visibility update races
klopez4212 Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions desktop/src/features/channels/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,13 +348,10 @@ export function useUpdateChannelMutation(channelId: string | null) {

return updateChannel({ ...input, channelId });
},
onMutate: () => ({ channelId }),
onSuccess: (updatedChannel) => {
if (!channelId) {
return;
}

queryClient.setQueryData<ChannelDetail>(
channelDetailQueryKey(channelId),
channelDetailQueryKey(updatedChannel.id),
updatedChannel,
);
queryClient.setQueryData<Channel[]>(channelsQueryKey, (current = []) =>
Expand All @@ -365,17 +362,17 @@ export function useUpdateChannelMutation(channelId: string | null) {
),
);
},
onSettled: () => {
onSettled: (_data, _error, _variables, context) => {
// refetchType "none": onSuccess already cached the relay-returned detail;
// awaiting the full channel-list refetch kept the edit dialog stuck on
// "Saving..." (same failure #1360 fixed for create).
void queryClient.invalidateQueries({
queryKey: channelsQueryKey,
refetchType: "none",
});
if (channelId) {
if (context?.channelId) {
void queryClient.invalidateQueries({
queryKey: channelDetailQueryKey(channelId),
queryKey: channelDetailQueryKey(context.channelId),
refetchType: "none",
});
}
Expand Down
Loading
Loading