chore: finish sprout->buzz rename in relay env vars and public-facing strings#2611
Open
SeanGearin wants to merge 1 commit into
Open
chore: finish sprout->buzz rename in relay env vars and public-facing strings#2611SeanGearin wants to merge 1 commit into
SeanGearin wants to merge 1 commit into
Conversation
… strings Signed-off-by: Sean Gearin <sgearin@gmail.com>
SeanGearin
force-pushed
the
chore-sprout-buzz-residue
branch
from
July 23, 2026 20:20
d79beec to
e589d58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The block/sprout -> block/buzz rename left residue in public-facing strings and, more importantly, in three relay environment variables that still use the old
SPROUT_prefix while every other relay knob isBUZZ_-prefixed:SPROUT_MAX_NOT_BEFORE_DELTA— read in two places (crates/buzz-relay/src/nip11.rsandcrates/buzz-relay/src/handlers/ingest.rs); it is both advertised in the NIP-11 relay information document (limitation.max_not_before_delta) and enforced on NIP-ER reminder ingest, so the relay literally self-identifies with a stale config surface.SPROUT_REMINDER_SCHEDULER_INTERVAL_SECS/SPROUT_REMINDER_SCHEDULER_BATCH_LIMIT— read incrates/buzz-relay/src/main.rsfor the NIP-ER push scheduler.Plus cosmetic residue: the NIP-AO reference-implementation link and a source comment still point at
github.com/block/sprout, a doc comment names the pre-renamesprout-dev-mcpcrate, and one buzz-acp test uses an internal pre-rename staging hostname as its example URL.Fix
BUZZ_*first with a fallback to the legacySPROUT_*name, so existing deployments that persisted the old names keep their configured horizon/scheduler tuning — no behavior change for anyone. Comments at each read site note the legacy fallback. A follow-up can drop the fallback once deployments have migrated..github/workflows/ci.ymlnow setsBUZZ_REMINDER_SCHEDULER_INTERVAL_SECS=1(2 lines), so CI's e2e relay jobs exercise the new name end-to-end.docs/nips/NIP-AO.mdreference-implementation link and ahandlers/side_effects.rscomment updated togithub.com/block/buzz(GitHub redirects the old URLs, but the text no longer names the dead repo).crates/buzz-agent/src/config.rsdoc comment:sprout-dev-mcp->buzz-dev-mcp(the crate's actual name).crates/buzz-acp/src/config.rstest:wss://sprout-oss.stage.blox.sqprod.co->wss://relay.example.com, matching the sibling tests' example hosts and removing an internal hostname from the public repo.crates/buzz-test-client/tests/e2e_event_reminder.rsdoc comment updated to the new scheduler var name.Deliberately NOT touched (intentional references):
squareup/sprout-*internal-repo references in AGENTS.md/CONTRIBUTING.md; legacy-migration/cleanup code inscripts/dev-setup.sh,scripts/instance-env.sh,scripts/reset-desktop-dev-state.sh(they migrate/clean old sprout-named state by design);scripts/check-pr-image-urls.sh(its pattern intentionally matches the old internal media host); thesprout_refBuildkite input in RELEASING.md and workflows (an internal pipeline's real input name); theSPROUT_UPDATER_PUBLIC_KEYsecret fallback in release.yml (already a deliberate compat fallback); the historicalcrates/sprout-relay/...pre-rewrite reference inconformance_multitenant.rs; Cargo.toml repository URLs (covered by PR #2519) and thesprout-cliskill dirs (covered by PR #2525); CHANGELOG/git history.Test evidence
cargo fmt -p buzz-relay -p buzz-acp -p buzz-agent -p buzz-test-client --check— clean.cargo check -p buzz-relay -p buzz-acp -p buzz-agent— clean.cargo clippy -p buzz-relay -p buzz-acp -p buzz-agent -- -D warnings— clean.unwrap()/expect()introduced; env reads keep the existing.ok().and_then(...).unwrap_or(default)shape.Links