Skip to content

feat(desktop): add search to agent emoji picker - #2630

Merged
cameronhotchkies merged 1 commit into
block:mainfrom
TheSentinel454:tornquist/agent-emoji-search
Jul 27, 2026
Merged

feat(desktop): add search to agent emoji picker#2630
cameronhotchkies merged 1 commit into
block:mainfrom
TheSentinel454:tornquist/agent-emoji-search

Conversation

@TheSentinel454

@TheSentinel454 TheSentinel454 commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why

The agent avatar picker disables Emoji Mart search, making emojis difficult to find when creating or editing an agent.

What

  • Enable sticky search in the shared agent avatar picker
  • Focus the search field when the Emoji tab opens
  • Add end-to-end coverage for search, focus, and selection

Risk Assessment

Low — this is limited to the desktop agent avatar picker and does not change avatar persistence or agent configuration.

References

  • pnpm --dir desktop test — 3,448 passed
  • pnpm --dir desktop typecheck — passed
  • pnpm --dir desktop exec playwright test tests/e2e/agents.spec.ts — 20 passed

Update Jul 24, 16:28 EDT: Completed CONTRIBUTING.md validation.

Manual test

  1. Create an agent and open Add avatar → Emoji.
  2. Confirm the search field is focused and filters results.
  3. Select an emoji and confirm it becomes the avatar.
  4. Repeat while editing an existing agent.

Validation

  • just ci — passed
  • just test — passed

Follow-up work

None.

Generated with Codex

@TheSentinel454
TheSentinel454 marked this pull request as ready for review July 24, 2026 13:04
@TheSentinel454
TheSentinel454 requested a review from a team as a code owner July 24, 2026 13:04
@TheSentinel454

TheSentinel454 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Agent emoji search in the create/edit agent avatar picker:

agent-emoji-search

wesbillman
wesbillman approved these changes Jul 24, 2026
View reviewed changes

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at 3586c10. The search/focus behavior is narrowly scoped and the shadow-root focus retry is cleaned up correctly. I also verified desktop check, typecheck, all 3,448 desktop unit tests, and the full agents E2E spec (20/20).

@TheSentinel454 TheSentinel454 changed the title Add search to agent emoji picker feat(desktop): add search to agent emoji picker Jul 24, 2026
@cameronhotchkies
cameronhotchkies merged commit 313f793 into block:main Jul 27, 2026
25 checks passed
wpfleger96 added a commit to bcrdejong/buzz that referenced this pull request Jul 27, 2026
@wpfleger96
Merge remote-tracking branch 'origin/main' into duncan-pr3023-fmt
7592a6e 
* origin/main:
  feat(desktop): add search to agent emoji picker (block#2630)
  fix(desktop): keep identity key help dialog readable in dark mode (block#2854)
  feat(acp): title agent sessions from the agent and channel name (block#3028)

# Conflicts:
#	desktop/scripts/check-file-sizes.mjs
@wpfleger96 wpfleger96 mentioned this pull request Jul 27, 2026
Merged
tellaho pushed a commit that referenced this pull request Jul 27, 2026
npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w
Merge remote-tracking branch 'origin/main' into tho/byoh-ux-polish
c2491a2 
* origin/main:
  feat(desktop): add search to agent emoji picker (#2630)
  fix(desktop): keep identity key help dialog readable in dark mode (#2854)
  feat(acp): title agent sessions from the agent and channel name (#3028)
  feat(mobile): bring message actions to desktop parity (#3070)
  feat(git): use agent display name as git author name (#3040)
  fix(security): enforce durable community ban on NIP-43 relay-admin kinds 9030-9033 (#3128)
  chore(deps): update react monorepo to v19.2.8 (#3064)
  fix(deps): bump nostr to 0.44.6 for RUSTSEC-2026-0216 (NIP-44 remote DoS) (#3135)
  docs(contributing): set PR expectations and require UI screenshots (#3140)
  fix(desktop): read the newest pair-scoped harness log (#3134)
  fix(security): authorize kind:9000 role changes in both directions (#3017)
  feat(desktop): handle project work from Inbox (#3117)
  fix(desktop): clarify identity key button when key exists (#2357)
  Restore Goose and Buzz Agent to onboarding harness selection (#2731)
  fix(mobile): mitigate message-post delay with optimistic rendering (#3037)
  fix(desktop): render rich project work item content (#3100)
  chore(deps): update radix-ui-primitives monorepo (#3063)
  chore(deps): update dependency @tanstack/react-virtual to v3.14.8 (#3057)

Signed-off-by: npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w <52a228d6edf316ec6812ac3c9fc0d696ab59fc7954d77e7be31eedcddf91335b@buzz.block.builderlab.xyz>
tellaho added a commit that referenced this pull request Jul 27, 2026
npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w @tellaho
chore(desktop): ratchet file-size override for AgentCreationPreview f…
9d0ef66 
…rom main

origin/main's #2630 grew AgentCreationPreview.tsx to 1026 lines with no
override; this branch never touches the file. Narrow inherited ratchet
so the push gate stays green.

Co-authored-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
wpfleger96 added a commit that referenced this pull request Jul 27, 2026
@wpfleger96
chore(desktop): add AgentCreationPreview file-size override to unbloc…
b92a1f4 
…k main CI (#3154)

`Desktop Core` is currently red on `main`, and every open PR that picks
up current main inherits the failure.

[#2630](#2630) added a shadow-root
search-input autofocus effect to `AgentCreationPreview.tsx`, taking the
file from 999 to 1026 lines. It sat one line under the 1000-line default
beforehand, so that PR's own CI was green while the merged file crossed
the cap with no override entry in
`desktop/scripts/check-file-sizes.mjs`.

This adds the missing entry at 1026, following the pattern the rest of
the overrides list uses. The split stays queued along with the others.

```
- src/features/agents/ui/AgentCreationPreview.tsx: 1026 lines (limit 1000)
```

The override is tight in both directions: at `1026` the gate passes, and
at `1025` it reproduces the failure above.

Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
tlongwell-block pushed a commit that referenced this pull request Jul 27, 2026
npub1qyvc0c5kl4gqv2fd97fsk46tu378sqgy35vc83rvgfwne90sel7s0ed67d
Merge origin/main into eva/security-combined-fix (CI unblock)
b73b559 
Inherits the #3154 file-size override for AgentCreationPreview.tsx that
turned Desktop Core red on every PR's synthetic merge, plus #2615 and
Windows test-gate fixes.

Co-authored-by: Tyler Longwell <tlongwell@block.xyz>
Signed-off-by: Tyler Longwell <tlongwell@block.xyz>

* origin/main:
  chore(desktop): add AgentCreationPreview file-size override to unblock main CI (#3154)
  fix(cli,relay): resolve agents by verified owner (#2615)
  fix(desktop): make the test loader work on Windows (#2758)
  fix(desktop): make lint and unit-test gates work on Windows (#2943)
  feat(mobile): refactor Activity behavior and ui (#2889)
  feat(desktop): add search to agent emoji picker (#2630)
  fix(desktop): keep identity key help dialog readable in dark mode (#2854)
  feat(acp): title agent sessions from the agent and channel name (#3028)
  feat(mobile): bring message actions to desktop parity (#3070)
  feat(git): use agent display name as git author name (#3040)

Signed-off-by: npub1qyvc0c5kl4gqv2fd97fsk46tu378sqgy35vc83rvgfwne90sel7s0ed67d <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz>
@Cvv9 Cvv9 mentioned this pull request Jul 27, 2026
Open
wpfleger96 added a commit to SeanGearin/buzz that referenced this pull request Jul 27, 2026
@wpfleger96
Merge remote-tracking branch 'origin/main' into pr2607
1429561 
* origin/main: (102 commits)
  chore(desktop): add AgentCreationPreview file-size override to unblock main CI (block#3154)
  fix(cli,relay): resolve agents by verified owner (block#2615)
  fix(desktop): make the test loader work on Windows (block#2758)
  fix(desktop): make lint and unit-test gates work on Windows (block#2943)
  feat(mobile): refactor Activity behavior and ui (block#2889)
  feat(desktop): add search to agent emoji picker (block#2630)
  fix(desktop): keep identity key help dialog readable in dark mode (block#2854)
  feat(acp): title agent sessions from the agent and channel name (block#3028)
  feat(mobile): bring message actions to desktop parity (block#3070)
  feat(git): use agent display name as git author name (block#3040)
  fix(security): enforce durable community ban on NIP-43 relay-admin kinds 9030-9033 (block#3128)
  chore(deps): update react monorepo to v19.2.8 (block#3064)
  fix(deps): bump nostr to 0.44.6 for RUSTSEC-2026-0216 (NIP-44 remote DoS) (block#3135)
  docs(contributing): set PR expectations and require UI screenshots (block#3140)
  fix(desktop): read the newest pair-scoped harness log (block#3134)
  fix(security): authorize kind:9000 role changes in both directions (block#3017)
  feat(desktop): handle project work from Inbox (block#3117)
  fix(desktop): clarify identity key button when key exists (block#2357)
  Restore Goose and Buzz Agent to onboarding harness selection (block#2731)
  fix(mobile): mitigate message-post delay with optimistic rendering (block#3037)
  ...
wpfleger96 added a commit to SeanGearin/buzz that referenced this pull request Jul 27, 2026
@wpfleger96
Merge remote-tracking branch 'origin/main' into pr2606
0df74f3 
* origin/main: (102 commits)
  chore(desktop): add AgentCreationPreview file-size override to unblock main CI (block#3154)
  fix(cli,relay): resolve agents by verified owner (block#2615)
  fix(desktop): make the test loader work on Windows (block#2758)
  fix(desktop): make lint and unit-test gates work on Windows (block#2943)
  feat(mobile): refactor Activity behavior and ui (block#2889)
  feat(desktop): add search to agent emoji picker (block#2630)
  fix(desktop): keep identity key help dialog readable in dark mode (block#2854)
  feat(acp): title agent sessions from the agent and channel name (block#3028)
  feat(mobile): bring message actions to desktop parity (block#3070)
  feat(git): use agent display name as git author name (block#3040)
  fix(security): enforce durable community ban on NIP-43 relay-admin kinds 9030-9033 (block#3128)
  chore(deps): update react monorepo to v19.2.8 (block#3064)
  fix(deps): bump nostr to 0.44.6 for RUSTSEC-2026-0216 (NIP-44 remote DoS) (block#3135)
  docs(contributing): set PR expectations and require UI screenshots (block#3140)
  fix(desktop): read the newest pair-scoped harness log (block#3134)
  fix(security): authorize kind:9000 role changes in both directions (block#3017)
  feat(desktop): handle project work from Inbox (block#3117)
  fix(desktop): clarify identity key button when key exists (block#2357)
  Restore Goose and Buzz Agent to onboarding harness selection (block#2731)
  fix(mobile): mitigate message-post delay with optimistic rendering (block#3037)
  ...
wpfleger96 added a commit to jatinder14/buzz that referenced this pull request Jul 27, 2026
@wpfleger96
Merge remote-tracking branch 'origin/main' into pr2871
687d137 
* origin/main: (22 commits)
  chore(desktop): add AgentCreationPreview file-size override to unblock main CI (block#3154)
  fix(cli,relay): resolve agents by verified owner (block#2615)
  fix(desktop): make the test loader work on Windows (block#2758)
  fix(desktop): make lint and unit-test gates work on Windows (block#2943)
  feat(mobile): refactor Activity behavior and ui (block#2889)
  feat(desktop): add search to agent emoji picker (block#2630)
  fix(desktop): keep identity key help dialog readable in dark mode (block#2854)
  feat(acp): title agent sessions from the agent and channel name (block#3028)
  feat(mobile): bring message actions to desktop parity (block#3070)
  feat(git): use agent display name as git author name (block#3040)
  fix(security): enforce durable community ban on NIP-43 relay-admin kinds 9030-9033 (block#3128)
  chore(deps): update react monorepo to v19.2.8 (block#3064)
  fix(deps): bump nostr to 0.44.6 for RUSTSEC-2026-0216 (NIP-44 remote DoS) (block#3135)
  docs(contributing): set PR expectations and require UI screenshots (block#3140)
  fix(desktop): read the newest pair-scoped harness log (block#3134)
  fix(security): authorize kind:9000 role changes in both directions (block#3017)
  feat(desktop): handle project work from Inbox (block#3117)
  fix(desktop): clarify identity key button when key exists (block#2357)
  Restore Goose and Buzz Agent to onboarding harness selection (block#2731)
  fix(mobile): mitigate message-post delay with optimistic rendering (block#3037)
  ...
kalvinnchau pushed a commit that referenced this pull request Jul 27, 2026
npub122y0pqkertljmedu303rl0aqrj3w8pvu43t6jxm6875lzg6f2pwqegc3xc
Merge origin/main into am/admin-report-message-content
8a6257d 
Co-authored-by: Kalvin Chau <kalvin@block.xyz>

Signed-off-by: Kalvin Chau <kalvin@block.xyz>

* origin/main:
  chore(deps): update plugin org.jetbrains.kotlin.android to v2.2.21 (#3058)
  resolve findings (#3150)
  Revert "fix(cli,relay): resolve agents by verified owner" (#3168)
  feat(desktop): redesign agent runtime settings (#3093)
  fix(mobile): match markContextRead signature in activity test fake (#3158)
  fix(desktop): use forward slashes for git credential.helper on Windows (#3023)
  fix(mobile): tapping threaded message in Inbox navigates to top level of channel  (#2103)
  fix(mobile): retry channel-sections startup sync when relay rate-limits cold start (#3004)
  chore(desktop): add AgentCreationPreview file-size override to unblock main CI (#3154)
  fix(cli,relay): resolve agents by verified owner (#2615)
  fix(desktop): make the test loader work on Windows (#2758)
  fix(desktop): make lint and unit-test gates work on Windows (#2943)
  feat(mobile): refactor Activity behavior and ui (#2889)
  feat(desktop): add search to agent emoji picker (#2630)
  fix(desktop): keep identity key help dialog readable in dark mode (#2854)
  feat(acp): title agent sessions from the agent and channel name (#3028)
  feat(mobile): bring message actions to desktop parity (#3070)

Signed-off-by: npub122y0pqkertljmedu303rl0aqrj3w8pvu43t6jxm6875lzg6f2pwqegc3xc <5288f082d91aff2de5bc8be23fbfa01ca2e3859cac57a91b7a3fa9f12349505c@buzz.block.builderlab.xyz>
kalvinnchau pushed a commit that referenced this pull request Jul 27, 2026
npub1dccv64krpcpse5cmkzfeh998cftungyatw3djt8jwdw6g43f7fyqzzmrf7
Merge remote-tracking branch 'origin/main' into kalvin/limit-invite-l…
898a931 
…inks

* origin/main: (24 commits)
  Refine pending message status (#3153)
  feat(admin): show reported message content in report detail (#3149)
  fix(desktop): recover full local storage on startup (#3182)
  Replace mobile reconnect banners with skeleton shimmer (#3143)
  fix(desktop): keep collapsed table separators out of spoilers (#3169)
  chore(deps): update plugin org.jetbrains.kotlin.android to v2.2.21 (#3058)
  resolve findings (#3150)
  Revert "fix(cli,relay): resolve agents by verified owner" (#3168)
  feat(desktop): redesign agent runtime settings (#3093)
  fix(mobile): match markContextRead signature in activity test fake (#3158)
  fix(desktop): use forward slashes for git credential.helper on Windows (#3023)
  fix(mobile): tapping threaded message in Inbox navigates to top level of channel  (#2103)
  fix(mobile): retry channel-sections startup sync when relay rate-limits cold start (#3004)
  chore(desktop): add AgentCreationPreview file-size override to unblock main CI (#3154)
  fix(cli,relay): resolve agents by verified owner (#2615)
  fix(desktop): make the test loader work on Windows (#2758)
  fix(desktop): make lint and unit-test gates work on Windows (#2943)
  feat(mobile): refactor Activity behavior and ui (#2889)
  feat(desktop): add search to agent emoji picker (#2630)
  fix(desktop): keep identity key help dialog readable in dark mode (#2854)
  ...

Signed-off-by: npub1dccv64krpcpse5cmkzfeh998cftungyatw3djt8jwdw6g43f7fyqzzmrf7 <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
Co-authored-by: npub1dccv64krpcpse5cmkzfeh998cftungyatw3djt8jwdw6g43f7fyqzzmrf7 <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
@wesbillman wesbillman mentioned this pull request Jul 27, 2026
Open
jatinder14 pushed a commit to jatinder14/buzz that referenced this pull request Jul 28, 2026
@wpfleger96
Merge remote-tracking branch 'origin/main' into pr2871
925dd0c 
* origin/main: (22 commits)
  chore(desktop): add AgentCreationPreview file-size override to unblock main CI (block#3154)
  fix(cli,relay): resolve agents by verified owner (block#2615)
  fix(desktop): make the test loader work on Windows (block#2758)
  fix(desktop): make lint and unit-test gates work on Windows (block#2943)
  feat(mobile): refactor Activity behavior and ui (block#2889)
  feat(desktop): add search to agent emoji picker (block#2630)
  fix(desktop): keep identity key help dialog readable in dark mode (block#2854)
  feat(acp): title agent sessions from the agent and channel name (block#3028)
  feat(mobile): bring message actions to desktop parity (block#3070)
  feat(git): use agent display name as git author name (block#3040)
  fix(security): enforce durable community ban on NIP-43 relay-admin kinds 9030-9033 (block#3128)
  chore(deps): update react monorepo to v19.2.8 (block#3064)
  fix(deps): bump nostr to 0.44.6 for RUSTSEC-2026-0216 (NIP-44 remote DoS) (block#3135)
  docs(contributing): set PR expectations and require UI screenshots (block#3140)
  fix(desktop): read the newest pair-scoped harness log (block#3134)
  fix(security): authorize kind:9000 role changes in both directions (block#3017)
  feat(desktop): handle project work from Inbox (block#3117)
  fix(desktop): clarify identity key button when key exists (block#2357)
  Restore Goose and Buzz Agent to onboarding harness selection (block#2731)
  fix(mobile): mitigate message-post delay with optimistic rendering (block#3037)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesbillman wesbillman wesbillman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheSentinel454 @wesbillman @cameronhotchkies