Skip to content

Refine the mobile message composer#2730

Merged
brow merged 9 commits into
mainfrom
kennylopez-mobile-composer
Jul 24, 2026
Merged

Refine the mobile message composer#2730
brow merged 9 commits into
mainfrom
kennylopez-mobile-composer

Conversation

@klopez4212

@klopez4212 klopez4212 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace the mobile composer sheet with a compact expanding capsule
  • add vertically stacked attachment actions and an inline camera preview
  • align suggestion, formatting, and send treatments with desktop

Validation

  • just mobile-check
  • just mobile-test (541 passed, 1 skipped)

@klopez4212
klopez4212 marked this pull request as ready for review July 24, 2026 17:04
@klopez4212
klopez4212 requested a review from a team as a code owner July 24, 2026 17:04
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 24, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3cfd0f694d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread mobile/lib/features/channels/compose_bar.dart Outdated
Comment thread mobile/lib/shared/relay/media_upload.dart
square-tomb
square-tomb approved these changes Jul 24, 2026
View reviewed changes
Comment thread mobile/lib/shared/relay/media_upload.dart Outdated
Comment thread mobile/lib/features/channels/compose_bar/attachments.dart Outdated
Comment thread mobile/lib/features/channels/compose_bar.dart
Comment thread mobile/lib/features/channels/compose_bar.dart
brow
brow requested changes Jul 24, 2026
View reviewed changes

@brow brow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments the team worth addressing and particularly this one seems worth blocking on

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 24, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f9924e9775

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread mobile/lib/features/channels/compose_bar.dart
Comment thread mobile/lib/shared/relay/media_upload.dart Outdated
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 24, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dd3872ed67

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread mobile/lib/shared/relay/media_upload.dart
Comment thread mobile/lib/features/channels/compose_bar/camera_preview.dart Outdated
npub102wg7q285p64ch2fjvstmf2ntn2sz3c4u5hmwatalc76mhsuauysftjtfj and others added 5 commits July 24, 2026 12:43
npub102wg7q285p64ch2fjvstmf2ntn2sz3c4u5hmwatalc76mhsuauysftjtfj
Restore composer emoji picker action
0532f36 
Co-authored-by: npub102wg7q285p64ch2fjvstmf2ntn2sz3c4u5hmwatalc76mhsuauysftjtfj <7a9c8f0147a0755c5d499320bda5535cd5014715e52fb7757dfe3dadde1cef09@buzz.block.builderlab.xyz>
Signed-off-by: npub102wg7q285p64ch2fjvstmf2ntn2sz3c4u5hmwatalc76mhsuauysftjtfj <7a9c8f0147a0755c5d499320bda5535cd5014715e52fb7757dfe3dadde1cef09@buzz.block.builderlab.xyz>
npub102wg7q285p64ch2fjvstmf2ntn2sz3c4u5hmwatalc76mhsuauysftjtfj
Open local attachments with media auth
6e89bce 
Co-authored-by: npub102wg7q285p64ch2fjvstmf2ntn2sz3c4u5hmwatalc76mhsuauysftjtfj <7a9c8f0147a0755c5d499320bda5535cd5014715e52fb7757dfe3dadde1cef09@buzz.block.builderlab.xyz>
Signed-off-by: npub102wg7q285p64ch2fjvstmf2ntn2sz3c4u5hmwatalc76mhsuauysftjtfj <7a9c8f0147a0755c5d499320bda5535cd5014715e52fb7757dfe3dadde1cef09@buzz.block.builderlab.xyz>
npub102wg7q285p64ch2fjvstmf2ntn2sz3c4u5hmwatalc76mhsuauysftjtfj
Delete temporary inline camera captures
eabeac0 
Co-authored-by: npub102wg7q285p64ch2fjvstmf2ntn2sz3c4u5hmwatalc76mhsuauysftjtfj <7a9c8f0147a0755c5d499320bda5535cd5014715e52fb7757dfe3dadde1cef09@buzz.block.builderlab.xyz>
Signed-off-by: npub102wg7q285p64ch2fjvstmf2ntn2sz3c4u5hmwatalc76mhsuauysftjtfj <7a9c8f0147a0755c5d499320bda5535cd5014715e52fb7757dfe3dadde1cef09@buzz.block.builderlab.xyz>
npub102wg7q285p64ch2fjvstmf2ntn2sz3c4u5hmwatalc76mhsuauysftjtfj
Update iOS pod lock for attachment opener
f1dda3a 
Co-authored-by: npub102wg7q285p64ch2fjvstmf2ntn2sz3c4u5hmwatalc76mhsuauysftjtfj <7a9c8f0147a0755c5d499320bda5535cd5014715e52fb7757dfe3dadde1cef09@buzz.block.builderlab.xyz>
Signed-off-by: npub102wg7q285p64ch2fjvstmf2ntn2sz3c4u5hmwatalc76mhsuauysftjtfj <7a9c8f0147a0755c5d499320bda5535cd5014715e52fb7757dfe3dadde1cef09@buzz.block.builderlab.xyz>
@klopez4212
Polish mobile composer capture and formatting
f8875d9
@brow
brow self-requested a review July 24, 2026 23:01
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 24, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f8875d95fb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread mobile/lib/features/channels/message_content.dart
Comment on lines +47 to +50
final file = File(
'${directory.path}${Platform.pathSeparator}'
'${DateTime.now().microsecondsSinceEpoch}-$safeName',
);

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Truncate downloaded attachment filenames after adding prefix

For relay media links whose filename is already near the 255-byte imeta limit, this constructs one temp-file path component as <timestamp>-$safeName. The timestamp prefix makes an otherwise valid attachment name exceed common iOS/Android filename component limits, so writeAsBytes fails and the user only sees “Could not open attachment.” Please reserve space for the prefix or use a short generated basename while preserving the extension.

Useful? React with 👍 / 👎.

Comment thread mobile/lib/features/channels/camera_capture_cleanup.dart

import 'package:image_picker/image_picker.dart';

Future<void> processCapturedImage(

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Document or hide the captured-image helper

This introduces a public mobile helper without a dartdoc, while the repo guide requires doc comments for new public API. Because it is only used by the private compose-bar part, please either make it private or add a doc comment so it does not become undocumented library surface.

AGENTS.md reference: AGENTS.md:L111-L114

Useful? React with 👍 / 👎.

@brow
brow merged commit 8398468 into main Jul 24, 2026
26 checks passed
@brow
brow deleted the kennylopez-mobile-composer branch July 24, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@brow brow brow approved these changes
+1 more reviewer
@square-tomb square-tomb square-tomb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@klopez4212 @brow @square-tomb