fix(workflow): bypass system proxies for webhooks#2800
Merged
tlongwell-block merged 1 commit intoJul 25, 2026
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019f96b5-e7dc-7292-9fe4-eee6b85e61e6 Co-authored-by: Amp <amp@ampcode.com>
tlongwell-block
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable automatic system-proxy discovery for workflow webhook requests.
Why
Webhook destinations are resolved, validated, and pinned before the request to prevent DNS-rebinding SSRF. If reqwest uses a system proxy, the proxy can resolve the original hostname itself instead of connecting to the validated address, bypassing that pinning guarantee.
Calling
no_proxy()keeps these security-sensitive requests on the directly validated connection path. Redirects remain disabled.Test plan
cargo fmt --all -- --checkcargo test -p buzz-workflow --features reqwest(149 passed)cargo clippy -p buzz-workflow --all-targets --features reqwest -- -D warningsgit diff --check