fix(acp): redact secret-shaped env values from wire logs and observer feeds#2869
Open
jatinder14 wants to merge 1 commit into
Open
fix(acp): redact secret-shaped env values from wire logs and observer feeds#2869jatinder14 wants to merge 1 commit into
jatinder14 wants to merge 1 commit into
Conversation
… feeds Agents can rebroadcast MCP configs (including plaintext API keys) in custom notifications. Scrub secret-shaped keys before acp::wire debug logs and observer emit so traces/transcripts never persist those values. Agent stdin/stdout is unchanged. Closes block#2819 Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Jatinder Mahajan <jatinder.mahajan@certifyos.com> Co-authored-by: Cursor <cursoragent@cursor.com>
jatinder14
force-pushed
the
fix/acp-redact-secret-shaped-env-logs
branch
from
July 25, 2026 17:57
c8ca7dd to
d44334b
Compare
|
Reporter here — thanks for the fast pickup. Reviewed against the actual payload I observed: the array-form
With point 1 addressed I'd consider this a complete fix for the buzz-acp half. 🐝 |
Author
|
Thanks for the review and for confirming the array-form |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*_API_KEY,*_TOKEN,*_SECRET, camelCaseapiKey, ACP{name,value}env pairs, …) beforeacp::wiredebug logs and observeracp_read/acp_writeemit.Fixes #2819
Test plan
cargo test -p buzz-acp --lib redact::RUST_LOG=acp::wire=debug, trigger an agent notification containing MCP env and confirm keys land as[REDACTED]in logs/Raw Event railMade with Cursor