fix(desktop): probe legacy Goose install dir on Windows - #3248
Merged
Conversation
johnmatthewtennant
added a commit
that referenced
this pull request
Jul 28, 2026
* origin/main: Publish symbol-bearing debug relay images (#3250) feat(tracing): add datastore tracing plumbing (#2760) fix(buzz-acp): accept id-keyed config options when resolving model switch (#2795) fix(desktop): probe legacy Goose install dir on Windows (#3248) refactor(desktop): extract install command execution into install_exec (#3251) Signed-off-by: John Tennant <jtennant@squareup.com>
tlongwell-block
pushed a commit
that referenced
this pull request
Jul 28, 2026
* origin/main: (70 commits) feat(relay): make Postgres pool size configurable, default 50 (#3191) Publish symbol-bearing debug relay images (#3250) feat(tracing): add datastore tracing plumbing (#2760) fix(buzz-acp): accept id-keyed config options when resolving model switch (#2795) fix(desktop): probe legacy Goose install dir on Windows (#3248) refactor(desktop): extract install command execution into install_exec (#3251) Polish composer activity layout and transitions (#3151) feat(invites): add use-limited invite links (#3141) fix(node): bump Buzz-supplied Node runtimes past OpenClaw's >=24.15.0 floor (#3218) fix(desktop): preserve thread anchor through layout reflow (#3212) feat(search): parse from:/in:/after:/before: and pass them in the filter (#2871) fix(desktop): fetch join policies through native networking (#2862) fix(desktop): republish agent identity records when a persona rename propagates (#2607) fix(desktop): keep project Inbox previews compact (#3193) Inbox refactor (#2045) Fix composer selection formatting and drop overlay (#3172) Refine pending message status (#3153) feat(admin): show reported message content in report detail (#3149) fix(desktop): recover full local storage on startup (#3182) Replace mobile reconnect banners with skeleton shimmer (#3143) ... Co-authored-by: Tyler Longwell <tlongwell@block.xyz> Signed-off-by: Tyler Longwell <tlongwell@block.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goose's pre-#2680 Windows installer unpacked the CLI to
%USERPROFILE%\goose\goose.exe. That directory is on no standardPATH, andcommon_binary_paths()never probed it, so users who installed Goose with the legacy installer stayed permanently undiscovered — the residual half of #2239.resolve_command_uncachedfinds binaries outsidePATHonly by scanningcommon_binary_paths(), so adding the directory there is the whole fix: Windows basename expansion already suppliesgoose.exe/.cmd/.bat, and discovery, readiness probes, and spawn all route through the same shared resolver. No Goose-specific resolution path is introduced. The entry sits beside the existing Codex%LOCALAPPDATA%\Programs\OpenAI\Codex\binprobe in the same#[cfg(windows)]block.The regression test is
#[cfg(windows)]and is CI-reachable, not dead code — thedesktop-build-windowsjob runscargo test --manifest-path desktop/src-tauri/Cargo.toml --target $env:TARGETonwindows-latest. It asserts the probe list rather than planting a binary:common_binary_pathsis a process-lifetimeOnceLock, so a test cannot deterministically re-seedUSERPROFILE, and planting an executable under the real user profile is not an acceptable side effect. Verified locally by widening thecfgto build on macOS — the test passes with the probe and fails without it.The
check-file-sizes.mjsoverride formanaged_agents/discovery.rsmoves 1835 → 1841, the exact post-cargo fmtgate count. Verified both directions: 1841 passes, 1840 fails.