Skip to content

fix(desktop): restore the inbox icon in the sidebar #3341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
delkc merged 1 commit into from
Jul 28, 2026
+10 −8
Merged

fix(desktop): restore the inbox icon in the sidebar #3341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions desktop/src/features/sidebar/ui/AppSidebarPinnedHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Activity, Bell, Bot, FolderGit2, Zap } from "lucide-react";
import { Activity, Bot, FolderGit2, Inbox, Zap } from "lucide-react";

import { TopbarSearch } from "@/features/search/ui/TopbarSearch";
import { FeatureGate } from "@/shared/features";
Expand Down Expand Up @@ -103,7 +103,7 @@ export function AppSidebarPrimaryMenu({
tooltip="Inbox"
type="button"
>
<Bell className="h-4 w-4" />
<Inbox className="h-4 w-4" />
<SidebarMenuLabel>Inbox</SidebarMenuLabel>
</SidebarMenuButton>
{homeBadgeCount > 0 ? (
Expand Down
14 changes: 8 additions & 6 deletions desktop/tests/e2e/inbox-refactor-screenshots.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ test.describe("inbox refactor screenshots", () => {
await page.screenshot({ path: `${SHOTS}/01-current-filters.png` });
});

test("02 — Inbox label, bell icon, and overflow controls", async ({
test("02 — Inbox label, inbox icon, and overflow controls", async ({
page,
}) => {
await installMockBridge(page, { mode: "mock" });
Expand All @@ -185,11 +185,13 @@ test.describe("inbox refactor screenshots", () => {
});

// The sidebar must be in frame — the label is the point of this shot.
await expect(
page
.getByTestId("sidebar-primary-menu")
.getByRole("button", { name: "Inbox", exact: true }),
).toBeVisible();
const inboxButton = page
.getByTestId("sidebar-primary-menu")
.getByRole("button", { name: "Inbox", exact: true });
await expect(inboxButton).toBeVisible();
// Inbox is a destination, not a notification tray, so it carries the inbox
// glyph rather than a bell. Asserted because nothing else pins the icon.
await expect(inboxButton.locator("svg.lucide-inbox")).toHaveCount(1);

await page.getByTestId("inbox-options-trigger").click();
await expect(page.getByText("Show unread only")).toBeVisible();
Expand Down