fix(chart): route /pair to the pairing relay in default HTTPRoute and Ingress rules - #3424
Open
Kampe wants to merge 1 commit into
Open
fix(chart): route /pair to the pairing relay in default HTTPRoute and Ingress rules#3424Kampe wants to merge 1 commit into
Kampe wants to merge 1 commit into
Conversation
… Ingress rules Signed-off-by: Kampe <blindside328@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With
pairingRelay.enabled: true, the chart deploys thebuzz-pair-relaysidecar and its Service — but neither the default HTTPRoute rules nor the chart-managed Ingress route anything to it. Mobile pairing then fails for every chart user who relies on the chart's own ingress objects:pairing_relay_url; operators who route ingress themselves may not have a/pairroute either way, but chart-managed ingress users get the default/→ relay rule only.wss://<host>/pairor the client falls back to the legacy/pairconvention, the request lands on the main relay, which serves no/pairroute (router.rs) → WebSocket upgrade 404, pairing dead.This is the Helm-chart sibling of #2734 / #3291 (same gap in
deploy/compose).Fix
When
pairingRelay.enabled:httproute.rulesstay untouched): add aPathPrefix /pairrule →<fullname>-pairing:<port>. Gateway API prefers the most specific match, so ordering is cosmetic./pairPrefix path → the pairing Service on every rendered host (longest-path matching peels it off the relay's/).The pair relay itself ignores the request path (
buzz-pair-relay/src/lib.rs: "Routes only /pair to this sidecar… The relay does not enforce path restrictions"), so no rewrite filter is needed.Verification
helm unittest: three new cases innetworking_test.yaml(no/pairrule when disabled; HTTPRoute default rules gain/pair+ keep/; Ingress default host gains/pair). Suite passes.wss://buzz.yugalabs.io(chart 0.1.6, ArgoCD + Envoy Gateway, equivalent route defined out-of-chart): NIP-11 advertiseswss://buzz.yugalabs.io/pair, WS upgrade on/pairreturns 101, iOS pairing completes.Related open PRs/issues: #2734, #3291 (compose-side; this PR is chart-side — none found targeting the chart).